[1.Description]: [RTL][Arieskk_v2.5][Flamekk_v2.5][Dialer]The Edit button on the header in call log page is not mirrored. See attachment:Dialer_Edit button.png [2.Testing Steps]: 1. Set your phone language to Arabic and launch Dialer. 2. Tap call log tab or miss call tab. 3. Observe the call log page. [3.Expected Result]: 3.The edit button on header should be left-aligned and mirrored. [4.Actual Result]: 3.The Edit button on header is not mirrored. [5.Reproduction build]: Device: AriesKK_2.5 [Affected] Build ID 20151023005002 Gaia Revision 29ce8ec8606e59f582375234440812b046346513 Gaia Date 2015-10-22 05:31:38 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/1f03a14106e59280761ac53904340f389674337f Gecko Version 44.0a1 Device Name aries Firmware(Release) 4.4.2 Firmware(Incremental) eng.worker.20151023.001128 Firmware Date Fri Oct 23 00:11:35 UTC 2015 Bootloader s1 Device: FlameKK_v2.5[Affected] Build ID 20151022150207 Gaia Revision 29ce8ec8606e59f582375234440812b046346513 Gaia Date 2015-10-22 05:31:38 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/76bd0c01d72e64ca4f261ffdb2652a91f961e930 Gecko Version 44.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20151022.185000 Firmware Date Thu Oct 22 18:50:13 EDT 2015 Base image v18d v4 Bootloader L1TC000118D0 [6.Reproduction Frequency]: Always Recurrence,5/5 [7.TCID]: 15428

Spec says "Do Not Mirror [...] Individual icons that are direction neutral". So the Edit button shouldn't be mirrored.

Thus closing bug as resolved invalid. QA: please make sure that test cases reflect this correctly. thanks

Actually this is valid per the spec, see this comment: https://bugzilla.mozilla.org/show_bug.cgi?id=1217773#c2. Reopening. QA: please make sure that test cases indeed reflect this correctly ;-) And sorry for the back-and-forth and confusion, this is an edge case really.

Comment on attachment 8681360 [details] [gaia] Phoxygen:bug1217761-shared_edit_mode_icon_rtl > mozilla-b2g:master Hi Gabriele, Turns out we need proper edit icons for rtl. Please r?

Comment on attachment 8681360 [details] [gaia] Phoxygen:bug1217761-shared_edit_mode_icon_rtl > mozilla-b2g:master LGTM but please re-compress the icons for the organic skin before committing. This command run from gaia root directory should do the trick (you'll need the optipng and advancecomp/advpng tools installed): ./tools/png_recompress.sh -v shared/style/headers/images/icons/organic/edit-rtl

Done, I've also added the ltr version of edit icons. Apparently 2 of them weren't compressed. Does that look better Gabriele?

Yes, that's fine and thanks for spotting the edit icons!

Comment on attachment 8681360 [details] [gaia] Phoxygen:bug1217761-shared_edit_mode_icon_rtl > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): none [User impact] if declined: Bad RTL experience [Testing completed]: on flame [Risk to taking this patch] (and alternatives if risky): Low, only css and icons change [String changes made]: none.

Comment on attachment 8681360 [details] [gaia] Phoxygen:bug1217761-shared_edit_mode_icon_rtl > mozilla-b2g:master Already in 2.5

This bug has been verified to "Fail" on the latest build of Aries KK 2.5/v2.6 and Flame KK v2.5/v2.6 512mb by STR in comment 0. Actual results: The Edit button on header is not mirrored. See attachment: Verify_Fail.png Reproduce rate: 10/10 Device: Aries KK 2.6 (master)(Fail) Build ID 20151107001102 Gaia Revision c3436122d678911d04b8f491724596116890ff9b Gaia Date 2015-11-06 18:22:03 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/e2a910c048dc82fc3be53475f18e7f81f03e377b Gecko Version 45.0a1 Device Name aries Firmware(Release) 4.4.2 Firmware(Incremental) eng.worker.20151106.232924 Firmware Date Fri Nov 6 23:29:32 UTC 2015 Bootloader s1 Device: Aries KK 2.5(Fail) Build ID 20151107112205 Gaia Revision 577948202ae12154524a2bd2bd6d467838ad50b8 Gaia Date 2015-11-07 10:00:59 Gecko Revision http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/ae7b8b1fd9e1504347b938820f99d75058049386 Gecko Version 44.0a2 Device Name aries Firmware(Release) 4.4.2 Firmware(Incremental) eng.worker.20151107.104119 Firmware Date Sat Nov 7 10:41:27 UTC 2015 Bootloader s1 Device: Flame KK 2.6 512mb (master)(Fail) Build ID 20151108150206 Gaia Revision c3436122d678911d04b8f491724596116890ff9b Gaia Date 2015-11-06 18:22:03 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/e2a910c048dc82fc3be53475f18e7f81f03e377b Gecko Version 45.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20151108.183921 Firmware Date Sun Nov 8 18:39:33 EST 2015 Firmware Version v18D v4 Bootloader L1TC000118D0 Device: Flame KK 2.5 512mb (Fail) Build ID 20151108004501 Gaia Revision 577948202ae12154524a2bd2bd6d467838ad50b8 Gaia Date 2015-11-07 10:00:59 Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/ae7b8b1fd9e1504347b938820f99d75058049386 Gecko Version 44.0a2 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20151108.045623 Firmware Date Sun Nov 8 04:56:35 EST 2015 Firmware Version v18D v4 Bootloader L1TC000118D0

Hi Augustin: The bug can be reproduced on latest build of FlameKK v2.5/2.6 and Arieskk v2.5/2.6 could you help to recheck? thank you.

Confirmed. I forgot to make a patch for gaia-header.

Hey Wilson. We actually have a rtl version for the edit icon (it's not really mirrored, but the tick and the circles positions are swapped). Please r?, I'll make a gaia-patch once I have a version to point to.

Comment on attachment 8684871 [details] Link to Github pull-request: https://github.com/gaia-components/gaia-icons/pull/57 LANDED Before we stamp a new version and update Gaia, can you confirm that we don't get the FOUC we had a few weeks ago. With the new icons, launch the SMS app and compose a new sms. The icons in the header should be visible instantly and you should not see text like 'back'.

Just tested, it seems to be ok.

I guess we should stamp a major version right?

Stamped v1.0.0 :) https://github.com/gaia-components/gaia-icons/releases/tag/v1.0.0

Comment on attachment 8687891 [details] [gaia] Phoxygen:bug1217761-edit_icon > mozilla-b2g:master So putting Wilson for the shared part, Gabriele for the communications part and Gasolin for the settings part. Please r? Thanks :-)

Comment on attachment 8687891 [details] [gaia] Phoxygen:bug1217761-edit_icon > mozilla-b2g:master This is OK for the dialer. I'd rather take another 80 lines of CSS than having this copy-pasted everywhere where it can get out of sync and bit-rot just as many other pieces did.

Comment on attachment 8687891 [details] [gaia] Phoxygen:bug1217761-edit_icon > mozilla-b2g:master Monday is a hard day :-/

Comment on attachment 8687891 [details] [gaia] Phoxygen:bug1217761-edit_icon > mozilla-b2g:master Please update gaia-icons inside Camera and Music apps to *exactly* the same version as in `shared/elements/`.

Hey Gasolin, I've left some questions on github for you. Thanks!

thanks for ping me, I left the suggestion in github.

Comment on attachment 8687891 [details] [gaia] Phoxygen:bug1217761-edit_icon > mozilla-b2g:master Overall looks good, Thanks! 2 nits are addressed on github, please take a look on them.

Hey Wilson, Fred, please r? again :-)

Apparently I've lost Gabriele's flag in the process :-( Not sure how I can put it back...

Comment on attachment 8687891 [details] [gaia] Phoxygen:bug1217761-edit_icon > mozilla-b2g:master Here you go.

Comment on attachment 8687891 [details] [gaia] Phoxygen:bug1217761-edit_icon > mozilla-b2g:master Thanks Autra. Sorry about this, but we have performance hack for icons which means all apps *must* run exactly the same versions. This is not the case for other external components :)

Comment on attachment 8687891 [details] [gaia] Phoxygen:bug1217761-edit_icon > mozilla-b2g:master please remove the `/` before `/share`.... then all good

(In reply to Fred Lin [:gasolin] from comment #32) > Comment on attachment 8687891 [details] > [gaia] Phoxygen:bug1217761-edit_icon > mozilla-b2g:master > > please remove the `/` before `/share`.... then all good Arf I forgot this one. Fix oushed. NI myself to ask for landing once tests are green.

The pull request says there are conflicts, so I can't hit the merge button. Can you please rebase it onto the current master?

Comment on attachment 8687891 [details] [gaia] Phoxygen:bug1217761-edit_icon > mozilla-b2g:master Hey Wilson, Re-asking your review, because gaia-icons have been updated , but without changing the version number in shared/bower.json. Did I get things right there?

Comment on attachment 8687891 [details] [gaia] Phoxygen:bug1217761-edit_icon > mozilla-b2g:master bug 1223733 landed an updated gaia-icons before you :)

This issue has been verified as pass on Arieskk_master and Flamekk_master. Rate:0/10 Device: Flame master_512mb [pass] Build ID 20151210150222 Gaia Revision 7e962276913bd4da7ce5fa7540767107ce322c78 Gaia Date 2015-12-09 21:27:39 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/412e4d7ce98ca4dbc37de133d0f26d7e1a59946f Gecko Version 45.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20151210.183953 Firmware Date Thu Dec 10 18:40:06 EST 2015 Firmware Version v18D v4 Bootloader L1TC000118D0 Device: Aries KK master [pass] Build ID 20151210120926 Gaia Revision 7e962276913bd4da7ce5fa7540767107ce322c78 Gaia Date 2015-12-09 21:27:39 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/412e4d7ce98ca4dbc37de133d0f26d7e1a59946f Gecko Version 45.0a1 Device Name aries Firmware(Release) 4.4.2 Firmware(Incremental) eng.worker.20151210.112747 Firmware Date Thu Dec 10 11:27:55 UTC 2015 Bootloader s1 Hi Carsten, Could you help to comfirm wheather this issue need to be fixed on v2.5.

Hi Alissa, i guess thats a good question for mahe. Mahe do we need this on 2.5 too ?

Not a major bug. Not required for 2.5 this late. Thanks

So I guess we should resolve this one, right?

That is right Augustin. Thanks

Per comment38 and comment40, change this issue as verified.