Closed Bug 1217887 Opened 9 years ago Closed 9 years ago

"href" is not defined in ContentClick.contentAreaClick

Categories

(Firefox :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 44
Tracking Status
firefox44 --- fixed

People

(Reporter: tabmix.onemen, Assigned: evilpie)

References

Details

(Keywords: regression)

Attachments

(1 file)

"href" is not defined in ContentClick.contentAreaClick (ContentClick.jsm)

>    try {
>      if (!PrivateBrowsingUtils.isWindowPrivate(window))
>        PlacesUIUtils.markPageAsFollowedLink(href);
>    } catch (ex) { /* Skip invalid URIs. */ }
yep, this is a valid regression introduced by bug 897062. Thank you.
Blocks: 897062
Keywords: regression
I guess it should be json.href
Flags: needinfo?(evilpies)
Yep.
Flags: needinfo?(evilpies)
Assignee: nobody → evilpies
Attached patch fix (deleted) — Splinter Review
Attachment #8679552 - Flags: review?(felipc)
Attachment #8679552 - Flags: review?(felipc) → review+
https://hg.mozilla.org/mozilla-central/rev/e4969dfec36e
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: