Closed
Bug 1219073
Opened 9 years ago
Closed 9 years ago
Source location in heap tree should style/function like performance call tree
Categories
(DevTools :: Memory, defect)
DevTools
Memory
Tracking
(firefox44 fixed)
RESOLVED
FIXED
Firefox 44
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: fitzgen, Assigned: jsantell)
References
Details
Attachments
(2 files)
|
(deleted),
patch
|
irakli
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
fitzgen
:
review+
|
Details | Diff | Splinter Review |
Right now it is plain text. Should be a link to view the line in the debugger.
|
Assignee | |
Comment 1•9 years ago
|
||
* Should link to debugger
* Be styled like performance call tree
* Full path on hover
* Just show filename
Summary: source location in "allocation stack" breakdown's tree items should link to source in the debugger → Source location in heap tree should style/function like performance call tree
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•9 years ago
|
||
Attachment #8680152 -
Flags: review?(rFobic)
|
||
Updated•9 years ago
|
Attachment #8680152 -
Flags: review?(rFobic) → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
This'll need a test too
Attachment #8680202 -
Flags: review?(nfitzgerald)
|
Reporter | |
Comment 5•9 years ago
|
||
Comment on attachment 8680202 [details] [diff] [review]
1219073-pt2.patch
Review of attachment 8680202 [details] [diff] [review]:
-----------------------------------------------------------------
::: devtools/client/memory/app.js
@@ +29,5 @@
> getChildContext() {
> return {
> front: this.props.front,
> heapWorker: this.props.heapWorker,
> + toolbox: this.props.toolbox,
File a follow up to have an `onOpenSourceLink` or whatever method instead of passing the toolbox in directly, as we talked about in person.
Attachment #8680202 -
Flags: review?(nfitzgerald) → review+
|
||
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/96b588073732
https://hg.mozilla.org/mozilla-central/rev/80a91d10efd8
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•