Closed
Bug 1219118
Opened 9 years ago
Closed 9 years ago
[Taskcluster] Disable all ics tests on m-c and integration branches
Categories
(Firefox Build System :: Task Configuration, task)
Firefox Build System
Task Configuration
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla45
People
(Reporter: edgar, Assigned: edgar)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
edgar
:
review+
|
Details | Diff | Splinter Review |
Since we all agree leave ICS on in BuildBot and focus on stabilizing emu-x86-kk test on taskcluster [1], I am wondering could we just disable all ics test on taskcluster, which can save resources on b2gtest-emulator workerType and also helps bug 1215766.
[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1209180#c7
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(garndt)
Assignee | ||
Comment 1•9 years ago
|
||
Comment 2•9 years ago
|
||
I'm not the owner of what should get tested for each product, but I know that at one point there were those that thought ICS was a platform we should be testing on.
I'm also including tzimmermann in on this because I think he has been working on the ICS emulator build/tests to get them running better.
As far as the attached patch specifically, I think that would do the trick.
Flags: needinfo?(garndt) → needinfo?(tzimmermann)
Assignee | ||
Comment 3•9 years ago
|
||
(In reply to Greg Arndt [:garndt] from comment #2)
> I'm not the owner of what should get tested for each product, but I know
> that at one point there were those that thought ICS was a platform we should
> be testing on.
>
> I'm also including tzimmermann in on this because I think he has been
> working on the ICS emulator build/tests to get them running better.
>
> As far as the attached patch specifically, I think that would do the trick.
ICS will still be enabled on the buildbot until we get a stable tests (on either emu-ics or emu-x86-kk) on TC. And for TC, IMO we could just skip emu-ics tests and focus on emu-x86-kk given that emu-ics tests will be deprecated eventually after migrating to emu-x86-kk.
Comment 4•9 years ago
|
||
(In reply to Edgar Chen [:edgar][:echen] from comment #3)
> (In reply to Greg Arndt [:garndt] from comment #2)
> > I'm not the owner of what should get tested for each product, but I know
> > that at one point there were those that thought ICS was a platform we should
> > be testing on.
> >
> > I'm also including tzimmermann in on this because I think he has been
> > working on the ICS emulator build/tests to get them running better.
> >
> > As far as the attached patch specifically, I think that would do the trick.
>
> ICS will still be enabled on the buildbot until we get a stable tests (on
> either emu-ics or emu-x86-kk) on TC. And for TC, IMO we could just skip
> emu-ics tests and focus on emu-x86-kk given that emu-ics tests will be
> deprecated eventually after migrating to emu-x86-kk.
Kind information: Edgar's comment is actually the conclusion in a previous discussion [1]. I didn't see something might change the consensus.
[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1209180#c8
Assignee | ||
Updated•9 years ago
|
Attachment #8679851 -
Flags: review?(garndt)
Comment 6•9 years ago
|
||
Comment on attachment 8679851 [details] [diff] [review]
WIP, Patch, v1
Based on the comment in the other bug and in the comments here, it appears that ICS tests are not stable nor needed on TC right now. They will continue running in buildbot and we will be working towards creating stable tests for x86 emulator on TC
Attachment #8679851 -
Flags: review?(garndt) → review+
Comment 7•9 years ago
|
||
Just be aware that depending on timing, bug 1218919 might affect landing of this patch because they are both touching the base jobs file. (touching different parts but should be ok).
Assignee | ||
Comment 8•9 years ago
|
||
(In reply to Greg Arndt [:garndt] from comment #7)
> Just be aware that depending on timing, bug 1218919 might affect landing of
> this patch because they are both touching the base jobs file. (touching
> different parts but should be ok).
I will wait for bug 1218919 to land first and do rebase. Thank you.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → echen
Assignee | ||
Comment 9•9 years ago
|
||
Carry r=garndt and rebase over bug 1218919.
Attachment #8679851 -
Attachment is obsolete: true
Attachment #8681172 -
Flags: review+
Assignee | ||
Comment 10•9 years ago
|
||
Comment 12•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Comment 13•9 years ago
|
||
bugherder uplift |
status-b2g-v2.5:
--- → fixed
Comment 14•9 years ago
|
||
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
Updated•7 years ago
|
Product: TaskCluster → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•