Closed
Bug 1219216
Opened 9 years ago
Closed 9 years ago
Fix a wrong comment in BackgroundHangMonitor.h
Categories
(Toolkit :: Telemetry, defect, P1)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla45
People
(Reporter: Dexter, Assigned: Dexter)
References
(Blocks 1 open bug)
Details
(Whiteboard: [measurement:client])
Attachments
(1 file)
|
(deleted),
patch
|
gfritzsche
:
review+
|
Details | Diff | Splinter Review |
In bug 1215466 comment 8 we found that the comment in [0] is wrong. We should change
"The background hang monitor is responsible for detecting and reporting hangs in background (non-main) threads."
to
"The background hang monitor is responsible for detecting and reporting hangs in main and background threads."
[0] - https://dxr.mozilla.org/mozilla-central/rev/6c7c983bce46a460c2766fbdd73283f6d2b03a69/xpcom/threads/BackgroundHangMonitor.h#29
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → alessio.placitelli
Blocks: 1201022
Points: --- → 1
Priority: -- → P1
Whiteboard: [measurement:client]
|
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8679984 -
Flags: review?(gfritzsche)
|
||
Updated•9 years ago
|
Attachment #8679984 -
Flags: review?(gfritzsche) → review?(vladan.bugzilla)
|
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8679984 [details] [diff] [review]
bug1219216.patch
Review of attachment 8679984 [details] [diff] [review]:
-----------------------------------------------------------------
Nevermind, this is clear from bug 1215466.
Attachment #8679984 -
Flags: review?(vladan.bugzilla) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/982da54f6ece66ff5a90fd4151f6a77d08dd58e8
Bug 1219216 - Fix a wrong comment in BackgroundHangMonitor.h. r=gfritzsche
|
||
Comment 4•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
|
||
Comment 5•9 years ago
|
||
| bugherder uplift | ||
status-b2g-v2.5:
--- → fixed
|
|
||
Comment 6•9 years ago
|
||
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
status-b2g-v2.5:
fixed → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•