Closed Bug 1219228 Opened 9 years ago Closed 9 years ago

Disabling WEBRTC causes build break on Android build

Categories

(Firefox Build System :: General, defect)

Unspecified
Android
defect
Not set
normal

Tracking

(firefox45 fixed, b2g-v2.5 fixed)

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed
b2g-v2.5 --- fixed

People

(Reporter: m_kato, Assigned: m_kato)

References

Details

Attachments

(1 file)

This changeset is incorrect. http://hg.mozilla.org/integration/mozilla-inbound/rev/92d510a09a8c changeset: 162889:92d510a09a8c user: Mike Shal <mshal@mozilla.com> date: Thu Jan 09 14:43:29 2014 -0500 summary: Bug 875013 - Remove VPATH in media/libvpx; r=joey This fix has the following. SOURCES += [ '%s/sources/android/cpufeatures/cpu-features.c' % CONFIG['ANDROID_NDK'], ] But this means, CSRCS += $TOPSRCDIR/$ANDROID_NDK/sources/... So this path is invalid.
Actually, that changeset was probably correct when it landed. But in the meantime, SOURCES semantics changed.
Specifically, adding '%%' at the beginning of that path should fix it (double % because of the formatting, so that the end result starts with a literal %, which now means absolute path).
(In reply to Mike Hommey [:glandium] from comment #2) > Specifically, adding '%%' at the beginning of that path should fix it > (double % because of the formatting, so that the end result starts with a > literal %, which now means absolute path). The path of cpu-features.c isn't into source directory and objdir directory, so it hits an assertion by "assert isinstance(f, ObjDirPath)" into emit.py.
Change it to be isinstance(f, Path)
Attachment #8680539 - Flags: review?(mh+mozilla)
Attachment #8680539 - Flags: review?(mh+mozilla) → review+
Assignee: nobody → m_kato
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: