Closed
Bug 1219623
Opened 9 years ago
Closed 9 years ago
Memory tool should handle responsiveness, multiple widths
Categories
(DevTools :: Memory, defect)
DevTools
Memory
Tracking
(firefox45 fixed)
RESOLVED
FIXED
Firefox 45
| Tracking | Status | |
|---|---|---|
| firefox45 | --- | fixed |
People
(Reporter: fitzgen, Assigned: jsantell)
References
Details
Attachments
(2 files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
patch
|
fitzgen
:
review+
|
Details | Diff | Splinter Review |
Screen Shot 2015-10-29 at 3.23.48 AM.png
No description provided.
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Summary: memory tool looks very... not good when docked on the right → Memory tool should handle responsiveness, multiple widths
|
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8680913 -
Flags: review?(nfitzgerald)
|
Reporter | |
Comment 2•9 years ago
|
||
Comment on attachment 8680913 [details] [diff] [review]
1219623-heap-responsive.patch
Review of attachment 8680913 [details] [diff] [review]:
-----------------------------------------------------------------
::: devtools/client/themes/memory.css
@@ +103,5 @@
>
> .list {
> margin: 0;
> padding: 0;
> + min-width: 186px;
Can we do 187 (on an undercover cop)
Attachment #8680913 -
Flags: review?(nfitzgerald) → review+
|
||
Comment 5•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
|
||
Comment 6•9 years ago
|
||
I don't understand how this patch landed on top of bug 1213100, the rebasing changed the code pretty much entirely. Furthermore, bug 1213100 should've fixed this already!
|
|
Assignee | |
Comment 7•9 years ago
|
||
bug 1213100 didn't fix a few responsiveness issues and this patch was done concurrently -- the merge was not nice and pretty much had to be rewritten -- opening up a post-Fx44 refactoring styles bug that this sorely needs
|
|
Reporter | |
Comment 8•9 years ago
|
||
|
|
||
Comment 9•9 years ago
|
||
| bugherder uplift | ||
status-b2g-v2.5:
--- → fixed
|
|
||
Comment 10•9 years ago
|
||
| bugherder uplift | ||
status-b2g-v2.5:
fixed → ---
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•