Per bug 1217472 comment 1, we should be packaging gcli in firefox jar files with the same layout it has in the source tree. That does not prevent having a shortcut that allows to load gcli via: require("gcli/system")

This patch also cleans up Loader.jsm from unecessary devtools/client > resource://devtools/client mapping. I removed gcli.jsm as it doesn't seem to be used anywhere? With this patch we can then map gcli to resource://devtools/shared/gcli/source/lib/ And resource://devtools now can be mapping to mozilla-central/devtools/, at least, regarding gcli...

Comment on attachment 8680602 [details] [diff] [review] patch v2 Review of attachment 8680602 [details] [diff] [review]: ----------------------------------------------------------------- ::: devtools/shared/gcli/gcli.jsm @@ -1,1 @@ > -/* I think this was kept for add-ons, but then we moved it, so they would be broken now anyway. I think it's fine to remove, but let's check with :jwalker.

Comment on attachment 8680602 [details] [diff] [review] patch v2 :jwalker, is it safe to remove gcli.jsm? It appears unused, but I wasn't sure about the details.

Comment on attachment 8680602 [details] [diff] [review] patch v2 Review of attachment 8680602 [details] [diff] [review]: ----------------------------------------------------------------- Kill it with fire.

Fixed the loader test, we now have only xpcshell-test mapping missing in srcdir-loader.

https://hg.mozilla.org/integration/fx-team/rev/3db104bc7a740fe52447b92a7a77dba0a2d3197a Bug 1219723 - Package gcli with the same layout than in the source tree. r=jryans