Alexandre Poirot [:ochameau] Assignee
	Description • 9 years ago

Per bug 1217472 comment 1, we should be packaging gcli in firefox jar files with the same layout it has in the source tree.
That does not prevent having a shortcut that allows to load gcli via:
  require("gcli/system")

	Alexandre Poirot [:ochameau] Assignee
	Comment 2 • 9 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b437456210b

	Alexandre Poirot [:ochameau] Assignee
	Comment 3 • 9 years ago

This patch also cleans up Loader.jsm from unecessary devtools/client > resource://devtools/client mapping.
I removed gcli.jsm as it doesn't seem to be used anywhere?

With this patch we can then map gcli to resource://devtools/shared/gcli/source/lib/
And resource://devtools now can be mapping to mozilla-central/devtools/,
at least, regarding gcli...

	J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)
	Comment 4 • 9 years ago

Comment on attachment 8680602 [details] [diff] [review]
patch v2

Review of attachment 8680602 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/shared/gcli/gcli.jsm
@@ -1,1 @@
> -/*

I think this was kept for add-ons, but then we moved it, so they would be broken now anyway.  I think it's fine to remove, but let's check with :jwalker.

	J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)
	Comment 5 • 9 years ago

Comment on attachment 8680602 [details] [diff] [review]
patch v2

:jwalker, is it safe to remove gcli.jsm?  It appears unused, but I wasn't sure about the details.

	Joe Walker [:jwalker]
	Comment 6 • 9 years ago

Comment on attachment 8680602 [details] [diff] [review]
patch v2

Review of attachment 8680602 [details] [diff] [review]:
-----------------------------------------------------------------

Kill it with fire.

	Alexandre Poirot [:ochameau] Assignee
	Comment 7 • 9 years ago

Fixed the loader test, we now have only xpcshell-test mapping missing in srcdir-loader.

	Alexandre Poirot [:ochameau] Assignee
	Comment 8 • 9 years ago

https://hg.mozilla.org/integration/fx-team/rev/3db104bc7a740fe52447b92a7a77dba0a2d3197a
Bug 1219723 - Package gcli with the same layout than in the source tree. r=jryans

	Carsten Book [:Tomcat]
	Comment 9 • 9 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/3db104bc7a74

	Carsten Book [:Tomcat]
	Comment 10 • 9 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/3db104bc7a74