Open
Bug 1220188
Opened 9 years ago
Updated 2 years ago
Memory tool spinner jitters nervously
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
NEW
Tracking | Status | |
---|---|---|
firefox45 | --- | affected |
People
(Reporter: callahad, Unassigned)
References
(Blocks 1 open bug, )
Details
(Keywords: DevAdvocacy, Whiteboard: [DevRel:P3])
Attachments
(3 files, 1 obsolete file)
(deleted),
image/gif
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
text/html
|
Details |
See attached gif
STR:
1. Open the memory tool
2. Click "Take Snapshot"
3. Watch the progress spinner
This is less apparent on Retina displays, but on traditional monitors it's very noticeable and distracting.
Comment 1•9 years ago
|
||
It's just /so/ excited for you!
Comment 2•9 years ago
|
||
This uses the same throbber as other tools, so other instances should Aldo be affected, like wrapping up a perftool recording. If this is a quick fix, let's do it, but will be tool wide.
If this is the same throbbed from bootstrap, I know that too has the same issue on Firefox.
Reporter | ||
Comment 3•9 years ago
|
||
Yep, I also see it on the perf tool. Less noticeable since I'm usually staring at the graphs instead of the spinner. :)
Comment 4•9 years ago
|
||
This is a pure CSS throbber, the code is here: https://dxr.mozilla.org/mozilla-central/source/devtools/client/themes/toolbars.inc.css#1049
Since it's pure CSS, this might be an issue with animations in general.
Comment 5•9 years ago
|
||
Ccing Patrick, might know more about the web animations side of this
Updated•9 years ago
|
No longer blocks: memory-tools-fx44
Updated•9 years ago
|
Blocks: memory-frontend
Updated•9 years ago
|
Has STR: --- → yes
Updated•9 years ago
|
Component: Developer Tools: Memory → CSS Parsing and Computation
Product: Firefox → Core
Comment 6•9 years ago
|
||
What's really strange is that removing and readding the animation tends to make it more stable.
Testcase here: http://jsfiddle.net/ntim/Ltaa7e26/
Comment 7•9 years ago
|
||
In chrome, the throbber isn't affected by the issue, so it's likely something on Firefox's side.
Comment 8•9 years ago
|
||
Does the problem disappear if you either replace "none" with "rotate(0deg)" or add a "will-change: transform" to the thing being animated? I wouldn't be surprised if the continuous transitions to/from "transform:none" mean this can't get animated on the compositor right now, since those transitions have to mess with frame bits at least...
Comment 9•9 years ago
|
||
I haven't been able to reproduce it locally, but here's a patch that forces the saving state to stay on for easier testing
Comment 10•9 years ago
|
||
Comment 11•9 years ago
|
||
Please attach testcases rather than posting jsFiddle links!
Comment 12•9 years ago
|
||
Attachment #8689801 -
Attachment is obsolete: true
Comment 13•9 years ago
|
||
So I think the problem you're talking about in comment 0 is the problem that the circle isn't quite staying centered, i.e., that it wobbles a bit. (If you're instead talking about animation smoothness, then you should say so. But is that what comment 6 is about?) I don't actually see the issue locally the way attachment 8681337 [details] shows, so it's hard to tell.
Does it improve if you give .throbber::before a font-size that is an integral number of pixels? Or perhaps a position that's an integral number of pixels offset from the edge of the body? Or perhaps even one that's an even number of pixels? It seems what attachment 8681337 [details] is showing could be caused by trying to rotate a circle about a point that isn't its exact center.
It seems like the layout code could be improved if that's the case, but I'm trying to check that I'm correctly understanding the issue you're reporting.
Flags: needinfo?(dan.callahan)
Reporter | ||
Comment 14•9 years ago
|
||
(In reply to David Baron [:dbaron] ⌚UTC-8 from comment #13)
> So I think the problem you're talking about in comment 0 is the problem that
> the circle isn't quite staying centered, i.e., that it wobbles a bit.
This is correct. The spinner does not remain centered during its animation.
Flags: needinfo?(dan.callahan)
Reporter | ||
Updated•9 years ago
|
Whiteboard: [DevRel:P3]
Updated•8 years ago
|
Flags: platform-rel?
Updated•8 years ago
|
platform-rel: --- → ?
Updated•8 years ago
|
platform-rel: ? → ---
Updated•2 years ago
|
Severity: minor → S4
You need to log in
before you can comment on or make changes to this bug.
Description
•