Revise pocket on TV menu item to "Pocket icon" + "Pocket"

Hi Peko, The Browser menu item for Pocket will be changed to "Pocket icon" + "Pocket". Could you provide the icon file format and size we need?

Please see attached file for pocket layout. Thanks

Hi Dan, Could you help to revise the menu item as described? Thanks!

Sure, I would take this.

Hi Dan, please check the new layout, thanks!

Hi Tori, files in the pocket_v2.zip seems broken. Please help check the file and update attachment, thanks.

File updated.

new pocket icon

got it !

Comment on attachment 8685330 [details] [gaia] danhuang1202:1220380_revise_pocket_menu_item_in_tv > mozilla-b2g:master Hi Yi-fan, please help review. This patch update pocket menu item and revise toolbar.css, thanks.

Comment on attachment 8685330 [details] [gaia] danhuang1202:1220380_revise_pocket_menu_item_in_tv > mozilla-b2g:master Thank you! 1. It seems we should change the string 'Pocket List' to 'Pocket' according to the spec? 2. The texts in the menu block are not vertically centered when hovering. 3. A couple questions on Github.

pocket menu item's padding size confirmed with UX

Thanks for the review! Merge in master: https://github.com/mozilla-b2g/gaia/commit/de66b4eb6a0abf86dfe4ca511cc6868c136f3d08

Comment on attachment 8685330 [details] [gaia] danhuang1202:1220380_revise_pocket_menu_item_in_tv > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): Bug 1194109 [User impact] if declined: strings and visual not align to spec [Testing completed]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=2fc7ecf3ff67370134bda1cf79cb8ba3c5273446 [Risk to taking this patch] (and alternatives if risky): None [String changes made]: Yes

Comment on attachment 8685330 [details] [gaia] danhuang1202:1220380_revise_pocket_menu_item_in_tv > mozilla-b2g:master Approve as part of Pocket feature in TV 2.5

I've just noticed that an icon was introduced with this commit which has not been compressed. It takes 300 KiB when it should take less than 1 KiB. Please run the compression script in the gaia tools and commit the compressed image instead (you'll need the optipng and advancecomp/advpng packages installed). From the gaia root directory execute the following command: ./tools/png_recompress -v \ tv_apps/browser/style/images/pocket_icon.png

Thanks for informing and kindly provide commend to compress png file. I created the follow up bug(Bug 1227836) to fix thie, thanks.

for 2.5 https://github.com/mozilla-b2g/gaia/commit/ff3ea3964ad6efdb885e5ffbcd14275f095b928d

Verified on: Branch v2.2 Commit 93b8bf2de3258c25199d97036c50a87667059148 Author: yifan <yliao@mozilla.com> Date: Fri Nov 6 14:25:58 2015 +0800 Branch: master Commit 7538cc11df132760010545f54379234a1862a8ae Merge: 2e5f63b 43f67ab Author: Ricky Chien <rickychien@users.noreply.github.com> Date: Wed Nov 25 18:38:29 2015 +0800