Closed
Bug 1220563
Opened 9 years ago
Closed 9 years ago
[Toaster] In LTR, text is right-aligned when notification created with dir="rtl"
Categories
(Firefox OS Graveyard :: Gaia::System::Status bar, Utility tray, Notification, defect)
Firefox OS Graveyard
Gaia::System::Status bar, Utility tray, Notification
ARM
Gonk (Firefox OS)
Tracking
(Not tracked)
RESOLVED
FIXED
FxOS-S11 (13Nov)
People
(Reporter: autra, Assigned: autra)
References
Details
Attachments
(2 files)
toaster_title_body_alignment.png
[Steps]
- put your phone in English
- connect your phone to the webIDE, with the System app
- create a new notification with a dir 'rtl', for example by executing
> new Notification('مسيبمن', {body: 'body', icon: 'http://icdn.pro/images/fr/1/u/1up-champignon-icone-9299-96.png', dir: 'rtl'})
in the console
- observe the toaster
[Expected]
- The title and body are left-aligned
[Actual]
- The title and body are right-aligned, see toaster_title_body_alignment.png
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → augustin.trancart
Status: NEW → ASSIGNED
|
||
Comment 1•9 years ago
|
||
|
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8681831 [details]
[gaia] Phoxygen:bug1220563-toaster_alignment > mozilla-b2g:master
Hi Etienne,
A quick patch to correct alignment in toaster. Apparently my patch in bug 1212329 missed this.
Attachment #8681831 -
Flags: review?(etienne)
|
||
Updated•9 years ago
|
Attachment #8681831 -
Flags: review?(etienne) → review+
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
||
Comment 3•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S11 (13Nov)
|
|
Assignee | |
Comment 4•9 years ago
|
||
Comment on attachment 8681831 [details]
[gaia] Phoxygen:bug1220563-toaster_alignment > mozilla-b2g:master
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): none
[User impact] if declined: bad RTL experience for notifications
[Testing completed]: on flame
[Risk to taking this patch] (and alternatives if risky): Low, only css change, but should be uplifted AFTER bug 1219618
[String changes made]: none
Attachment #8681831 -
Flags: approval-gaia-v2.5?
|
|
Assignee | |
Comment 5•9 years ago
|
||
Comment on attachment 8681831 [details]
[gaia] Phoxygen:bug1220563-toaster_alignment > mozilla-b2g:master
Clearing uplift, already in 2.5.
Attachment #8681831 -
Flags: approval-gaia-v2.5?
You need to log in
before you can comment on or make changes to this bug.
Description
•