Closed
Bug 1220682
Opened 9 years ago
Closed 9 years ago
Error handling in nsAutoJSString::init (the single-arg version) is busted
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla45
People
(Reporter: bzbarsky, Unassigned)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
It does:
332 return init(nsContentUtils::RootingCxForThread(), v);
but the two-arg init() can throw OOM exceptions as far as I can tell, and this code will leave those dangling.
Flags: needinfo?(huseby)
Flags: needinfo?(bobbyholley)
|
Reporter | |
Updated•9 years ago
|
Component: Build Config → DOM
|
||
Comment 1•9 years ago
|
||
Attachment #8682584 -
Flags: review?(bzbarsky)
|
|
Reporter | |
Comment 2•9 years ago
|
||
Comment on attachment 8682584 [details] [diff] [review]
Clear exceptions on single-arg init. v1
r=me
Attachment #8682584 -
Flags: review?(bzbarsky) → review+
|
||
Comment 4•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
|
|
||
Comment 5•9 years ago
|
||
| bugherder uplift | ||
status-b2g-v2.5:
--- → fixed
|
|
||
Updated•9 years ago
|
Flags: needinfo?(huseby)
Flags: needinfo?(bobbyholley)
|
Assignee | |
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•