Closed
Bug 1221073
Opened 9 years ago
Closed 9 years ago
Back to 512 tile size on HiDPI OS X
Categories
(Core :: Graphics: Layers, defect)
Tracking
()
RESOLVED
FIXED
mozilla45
| Tracking | Status | |
|---|---|---|
| firefox45 | --- | fixed |
People
(Reporter: mstange, Assigned: jnicol)
References
Details
(Keywords: regression)
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
Before bug 1210351, we were using 512 on non-HiDPI OS X and 1024 on HiDPI OS X. We're no longer using 1024 because we're capping the tile size at 512 now.
|
Assignee | |
Comment 1•9 years ago
|
||
Revert my patch for bug 1210351, but make snorp's heuristic aim for between 2 and 4 tiles per screen width, rather than between 1 and 2. Gives us 1024 on macbook pros, but keeps it at 512 on android phones with screen widths of 1440. (which is why we reduced it in the first place)
Attachment #8696785 -
Flags: review?(mstange)
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → jnicol
Status: NEW → ASSIGNED
|
Reporter | |
Comment 2•9 years ago
|
||
Comment on attachment 8696785 [details] [diff] [review]
Patch v1
Review of attachment 8696785 [details] [diff] [review]:
-----------------------------------------------------------------
Please use clamped() from nsAlgorithm.h.
Attachment #8696785 -
Flags: review?(mstange) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
Oops, the commit message was meant to say >2 <=4, not >=2 <4. Code is unchanged.
Attachment #8696793 -
Flags: review?(mstange)
|
|
Assignee | |
Comment 4•9 years ago
|
||
Use clamped
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8696793 -
Attachment is obsolete: true
Attachment #8696793 -
Flags: review?(mstange)
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8696785 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•9 years ago
|
||
Successful try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0bec96d4b057
requesting checkin please. thanks.
Keywords: checkin-needed
Keywords: checkin-needed
|
||
Comment 7•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in
before you can comment on or make changes to this bug.
Description
•