Comment on attachment 8682566 [details] [diff] [review] Add a ByFilename breakdown for JS::ubi::Node censuses Review of attachment 8682566 [details] [diff] [review]: ----------------------------------------------------------------- seems believable ::: js/src/vm/CommonPropertyNames.h @@ +158,5 @@ > macro(NFKC, NFKC, "NFKC") \ > macro(NFKD, NFKD, "NFKD") \ > macro(nonincrementalReason, nonincrementalReason, "nonincrementalReason") \ > + macro(noFilename, noFilename, "noFilename") \ > + macro(noStack, noStack, "noStack") \ extra spaces ::: js/src/vm/UbiNodeCensus.cpp @@ +317,5 @@ > + if (!obj) > + return nullptr; > + > + for (auto entryPtr = entries.begin(); entryPtr < entries.end(); entryPtr++) { > + auto& entry = **entryPtr; This can't be for (auto entry : entries) somehow? @@ +769,5 @@ > + > + public: > + ByFilename(Census& census, > + CountTypePtr& thenType, > + CountTypePtr& noFilenameType) indentation

(In reply to Steve Fink [:sfink, :s:] from comment #3) > ::: js/src/vm/UbiNodeCensus.cpp > @@ +317,5 @@ > > + if (!obj) > > + return nullptr; > > + > > + for (auto entryPtr = entries.begin(); entryPtr < entries.end(); entryPtr++) { > > + auto& entry = **entryPtr; > > This can't be > > for (auto entry : entries) > > somehow? For some reason I thought that mozilla::Vector didn't support range based for loops, but it turns out it does! \o/