Closed
Bug 1221330
Opened 9 years ago
Closed 9 years ago
Change the migration notification icon to the Firefox branding icon (per current release channel)
Categories
(Toolkit Graveyard :: Notifications and Alerts, defect)
Toolkit Graveyard
Notifications and Alerts
Tracking
(firefox44 fixed, firefox45 fixed, b2g-v2.5 fixed)
RESOLVED
FIXED
mozilla45
People
(Reporter: edwong, Assigned: lina)
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
ritu
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
0. allow at least one notification via this: http://people.mozilla.org/~ewong2/push-notification-test/
1. enable toolbox in Nightly/DevEd
[13:12] <kitcambridge> Tools > Web Developer > Toggle Tools. click gear, then check "Enable browser chrome and add-on debugging toolboxes" and "Enable remote debugging"
[13:12] <kitcambridge> then you'll have a new menu item: Tools > Web Developer > Browser Toolbox > Console
enter this:
Services.prefs.setIntPref("browser.migration.version", 31); Cc["@mozilla.org/browser/browserglue;1"].getService(Ci.nsIObserver).observe(null, "browser-glue-test", "force-ui-migration")
hit return
actual: you'll see the speech box with an exclamation point
expected: a few felt it look alarming like a warning icon, please replace it without the exclamation mark.
Reporter | ||
Comment 1•9 years ago
|
||
:bryan is this something you could generate an attach to the bug?
Flags: needinfo?(bbell)
Reporter | ||
Comment 2•9 years ago
|
||
bryan said this in another bug:
bbell@mozilla.com 2015-11-03 16:20:13 PST
Created attachment 8682823 [details]
notifications.png
The notification icon is only meant for use in places like the Control Panel where users need an icon that describes the feature. It should never be used in the actual notifications.
Notifications should show the Firefox icon, or the icon of the site sending the message. like in this example.
Flags: needinfo?(bbell)
Reporter | ||
Comment 3•9 years ago
|
||
Plan of record: Use the Channel branding icon (fx, beta, aurora, nightly) and no icon on mac, since Mac native notification displays it by default.
Assignee: nobody → kcambridge
Summary: Remove the exclamation mark from the migration notification icon → Change the migration notification icon to the Firefox branding icon (per current release channel)
Assignee | ||
Comment 4•9 years ago
|
||
Bug 1221330 - Use the app icon for XUL upgraded notifications alerts. r=MattN
Attachment #8683816 -
Flags: review?(MattN+bmo)
Updated•9 years ago
|
Attachment #8683816 -
Flags: review?(MattN+bmo) → review+
Comment 5•9 years ago
|
||
Comment on attachment 8683816 [details]
MozReview Request: Bug 1221330 - Use the app icon for XUL upgraded notifications alerts. r=MattN
https://reviewboard.mozilla.org/r/24439/#review21945
Thank for picking this up.
::: browser/components/nsBrowserGlue.js:2246
(Diff revision 1)
> + "chrome://branding/content/about-logo@2x.png";
It seems like the 2x version is much larger than would be needed on any platform so for better quality downscaling I think we should use the 1x version which is already 192px × 192px (therefore handing 96x96 on @2x)
Assignee | ||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/8d1b7cb0ee0c240decd31f3722db18891f05fc0d
Bug 1221330 - Show the app icon in the XUL upgraded notifications alert. r=MattN
Comment 7•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Assignee | ||
Comment 8•9 years ago
|
||
Comment on attachment 8683816 [details]
MozReview Request: Bug 1221330 - Use the app icon for XUL upgraded notifications alerts. r=MattN
Approval Request Comment
[Feature/regressing bug #]: "Notifications upgraded" alert (bug 1216271).
[User impact if declined]: The alert will use the icon from the notifications doorhanger on Windows, instead of the desired branding icon.
[Describe test coverage new/current, TreeHerder]: No automated tests. Manually verified on Windows.
[Risks and why]: The doorhanger icon may be alarming to users, and it's unclear that the alert is coming from Firefox.
[String/UUID change made/needed]: None.
Attachment #8683816 -
Flags: approval-mozilla-aurora?
status-firefox44:
--- → affected
Kit: I was looking at the patch and we seem to be using the 2x logo whereas Matt suggested we use the 1x logo in comment 5. Do we need to revise the patch to accommodate that comment or am I misreading the code?
Flags: needinfo?(kcambridge)
Assignee | ||
Updated•9 years ago
|
Attachment #8683816 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 10•9 years ago
|
||
Sorry about that, Ritu. I changed the logo to 1x when I checked the patch in, but forgot to update MozReview. Here's the updated patch.
Attachment #8683816 -
Attachment is obsolete: true
Flags: needinfo?(kcambridge)
Attachment #8685725 -
Flags: approval-mozilla-aurora?
Comment on attachment 8685725 [details] [diff] [review]
1221330.patch
Thanks Kit! Patch looks good, let's uplift to Aurora44.
Attachment #8685725 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 12•9 years ago
|
||
bugherder uplift |
Comment 13•9 years ago
|
||
bugherder uplift |
status-b2g-v2.5:
--- → fixed
Updated•1 year ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•