Closed Bug 1221356 Opened 9 years ago Closed 9 years ago

Don't package mozharness for Thunderbird builds

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox44 fixed, firefox45 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla45
Tracking Flags:
Tracking Status
firefox44 --- fixed
firefox45 --- fixed

People

(Reporter: aleth, Assigned: aleth)

References

Details

Attachments

(1 file)

Don't package mozharness for Thunderbird builds
(deleted), patch
gps
: review+
ritu
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Attempting to package mozharness.zip fails for c-c Thunderbird builds, causing a build orange: IOError: [Errno 2] No such file or directory: '/builds/slave/tb-c-cen-l64-00000000000000000/build/objdir-tb/dist/linux-x86_64/en-US/mozharness.zip' make[3]: *** [stage-package] Error 1
Blocks: 1209628
Attachment #8682827 - Flags: review?(gps)
Assignee: nobody → aleth
Status: NEW → ASSIGNED
If there were a more appropriate ifdef here that more directly checks for whether mozharness is being used, that would be great.
Comment on attachment 8682827 [details] [diff] [review] Don't package mozharness for Thunderbird builds Review of attachment 8682827 [details] [diff] [review]: ----------------------------------------------------------------- I wish there were a PACKAGE_MOZHARNESS variable. But that is scope bloat. This patch is fine.
Attachment #8682827 - Flags: review?(gps) → review+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
This is still causing a failure on comm-aurora, can we uplift?
Attachment #8682827 - Flags: approval-mozilla-aurora?
Comment on attachment 8682827 [details] [diff] [review] Don't package mozharness for Thunderbird builds Seems like a thunderbird build issue, just letting it pass through.
Attachment #8682827 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Keywords: checkin-needed
This landed in 45. Setting the status flag to clear it from our uplift queries.
status-firefox45: --- → fixed
Blocks: 1410203
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: