Closed Bug 1222083 Opened 9 years ago Closed 9 years ago

mochitest dom/media/test/test_bug879717.html fails with: Assertion failure: mSkiaGlue->GetGrContext() (No GrContext)

Categories

(Core :: Graphics: Canvas2D, defect)

Product:
Core
Component:
Graphics: Canvas2D
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla45
Tracking Flags:
Tracking Status
firefox45 --- fixed

People

(Reporter: lsalzman, Assigned: lsalzman)

References

Details

Attachments

(1 file)

verify that a Skia GL context is actually available before trying to use it in Canvas2D drawImage
(deleted), patch
jrmuizel
: review+
Details | Diff | Splinter Review
The Canvas 2D code has an optimization where it tries to switch the rendering mode from software to OpenGL is a sufficient number of certain operations are used. Once this happens, drawImage does adequately check if there is an available GL context before trying to use it. The result is that the mochitest dom/media/test/test_bug879717.html (and probably several others) fail. The problem originated with bug 880114.
Attachment #8683755 - Flags: review?(jmuizelaar) → review+
https://hg.mozilla.org/mozilla-central/rev/2cde1a08131a
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: