Andrew McCreight [:mccr8] Assignee
	Description • 9 years ago

It uses SpecialPowers.addPermission() instead of SpecialPowers.pushPermissions().

	Andrew McCreight [:mccr8] Assignee
	Comment 1 • 9 years ago

test_tcpsocket_enabled_with_perm.html has the same problem, and they are both simple fixes.

	Andrew McCreight [:mccr8] Assignee
	Comment 2 • 9 years ago

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=002fe94dc8fe

	Andrew McCreight [:mccr8] Assignee
	Comment 4 • 9 years ago

This test passes with e10s. The other two do not.

	Blake Kaplan (:mrbkap) (inactive)
	Comment 5 • 9 years ago

Comment on attachment 8685467 [details] [diff] [review]
part 1 - Fix use of addPermission in test_tcpsocket_enabled_with_perm.html and test_xhr_parameters.html.

Review of attachment 8685467 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/network/tests/test_tcpsocket_enabled_with_perm.html
@@ +17,5 @@
>    the tcp-socket permission has been granted.
>  **/
>  SimpleTest.waitForExplicitFinish();
> +SpecialPowers.pushPrefEnv({"set": [['dom.mozTCPSocket.enabled', true]]}, function() {
> +  SpecialPowers.pushPermissions([{type: "tcp-socket", allow: true, context: document}], runTest); });

Nit: I'd indent this as:

SpecialPowers.pushprefEnv(..., function() {
  SpecialPowers.pushPermissions(...);
});

	Andrew McCreight [:mccr8] Assignee
	Comment 6 • 9 years ago

(In reply to Blake Kaplan (:mrbkap) (please use needinfo!) from comment #5)
> Nit: I'd indent this as:

Oh yeah, that's less weird. Fixed.

	Pulsebot
	Comment 7 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/0a2ab9e74af2
https://hg.mozilla.org/integration/mozilla-inbound/rev/4796c2145d33
https://hg.mozilla.org/integration/mozilla-inbound/rev/e915959648c4

	Carsten Book [:Tomcat]
	Comment 8 • 9 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/0a2ab9e74af2
https://hg.mozilla.org/mozilla-central/rev/4796c2145d33
https://hg.mozilla.org/mozilla-central/rev/e915959648c4