Closed Bug 1223533 Opened 9 years ago Closed 9 years ago

[e10s] Loading banner ads leads to close the <select> popup

Categories

(Core :: Layout: Form Controls, defect)

Product:
Core
Component:
Layout: Form Controls
Version:
45 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla48
Tracking Flags:
Tracking Status
e10s m9+ ---
firefox46 --- wontfix
firefox47 --- wontfix
firefox48 --- fixed

People

(Reporter: over68, Assigned: cyu)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Don't hide the select popup on ireelevant pagehide events
(deleted), patch
mconley
: review+
Details | Diff | Splinter Review
Steps to reproduce: 1. Go to https://dl.dropboxusercontent.com/u/95157096/85f61cf7/g5di0eoqhq.html. 2. Disable the protection. 3. Open the <select> element. Actual results: Loading banner ad leads to close the <select> popup. See https://dl.dropboxusercontent.com/u/95157096/85f61cf7/kerrtu0gkn.mp4
I can reproduce on Mac. It works fine in non-e10s window.
OS: Windows 7 → All
Hardware: x86_64 → All
Status: UNCONFIRMED → NEW
Ever confirmed: true
tracking-e10s: --- → ?
No longer depends on: 1177310
Component: Untriaged → Layout: Form Controls
Product: Firefox → Core
User Agent Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:46.0) Gecko/20100101 Firefox/46.0 Build ID 20160204004009 Tested on Windows 7 x64 with the Aurora 46.0a2 build. I can reproduce the problem.
This filters out the pagehide events not targeted to the select element's ownerDocument (emitted from loading the banner in this test case).
Assignee: nobody → cyu
Attachment #8731629 - Flags: review?(mconley)
Comment on attachment 8731629 [details] [diff] [review] Don't hide the select popup on ireelevant pagehide events Review of attachment 8731629 [details] [diff] [review]: ----------------------------------------------------------------- Looks good! Thanks cyu!
Attachment #8731629 - Flags: review?(mconley) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/39d566b6138ebc9b46ce0d890f9cba5e90e24f7b Bug 1223533 - Don't hide the select popup on irrelevant pagehide events. r=mconley
https://hg.mozilla.org/mozilla-central/rev/39d566b6138e
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Cervantes, should this fix be uplifted to Aurora 47 in preparation for our e10s experiments on Beta 47?
status-firefox46: --- → wontfix
status-firefox47: --- → ?
Flags: needinfo?(cyu)
This is a bug fix and doesn't produces information we want from experiments. I don't think it necessary to uplift to Aurora 47.
Flags: needinfo?(cyu)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: