Eric Tsai (no more review request accepted) Reporter
	Description • 9 years ago

in bug 1197749, schien's comment on attachment 8682988 [details] [diff] [review], move remote control client page Gecko preference in Gaia. Since it's related with remote-control-client app

	KM Lee [:rexboy] (inactivate after Sep. 22)
	Comment 3 • 9 years ago

Comment on attachment 8685823 [details]
Store remote control client page preference in Gaia

Looks ok to me

	KM Lee [:rexboy] (inactivate after Sep. 22)
	Comment 4 • 9 years ago

with comment changes needed.

	Carsten Book [:Tomcat]
	Comment 5 • 9 years ago

https://github.com/mozilla-b2g/gaia/commit/3fb68dc7084a1339eb18a87a1a593a51448e56a8

	Fernando Jiménez Moreno [:ferjm]
	Comment 7 • 9 years ago

This commit breaks the linter https://treeherder.mozilla.org/logviewer.html#?job_id=2958432&repo=gaia

	Julien Wajsberg [:julienw]
	Comment 8 • 9 years ago

Comment on attachment 8687137 [details]
[gaia] ferjm:bug1223668.followup > mozilla-b2g:master

r=me if the try is green ;)

	Fernando Jiménez Moreno [:ferjm]
	Comment 9 • 9 years ago

https://github.com/mozilla-b2g/gaia/commit/fa426f2d2672b92a7939aed060e882bff5f9bac0

	Eric Tsai (no more review request accepted) Reporter
	Comment 10 • 9 years ago

Comment on attachment 8687137 [details]
[gaia] ferjm:bug1223668.followup > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):1223668
[User impact] if declined: TV remote control feature malfunction
[Testing completed]: local test passed
[Risk to taking this patch] (and alternatives if risky): less, only custom gecko preferences
[String changes made]: N/A

	Josh Cheng [:josh]
	Comment 11 • 9 years ago

Comment on attachment 8687137 [details]
[gaia] ferjm:bug1223668.followup > mozilla-b2g:master

Approve as required for TV remote control feature.

	Carsten Book [:Tomcat]
	Comment 12 • 9 years ago

hi, i tried to uplift this to 2.5 but it fails with :

updating local tracking ref 'refs/remotes/origin/v2.5'
Tomcats-MacBook-Pro-2:gaia Tomcat$ git cherry-pick 75e7653d9deed8abf76ebfd069f0dfefdbfb9a0b
error: could not apply 75e7653... Bug 1223668 - Follow up: Make linter happy. r=me
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

could you take a look and provide a 2.5 PR request. Thanks!

	Eric Tsai (no more review request accepted) Reporter
	Comment 14 • 9 years ago

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 1223668
[User impact] if declined: Remote Control mal-function
[Testing completed]: local test
[Risk to taking this patch] (and alternatives if risky): low, only default preference
[String changes made]:N/A

	Carsten Book [:Tomcat]
	Comment 15 • 9 years ago

laned on 2.5 https://github.com/mozilla-b2g/gaia/commit/5b660b5c68eb55b4ab8ee950acc251eaf90c33bf thanks Eric!

	Josh Cheng [:josh]
	Comment 16 • 9 years ago

Comment on attachment 8691862 [details]
PR for 2.5

Required for TV 2.5 remote control.

	Luke Chang [:lchang] (inactive)
	Comment 17 • 9 years ago

Comment on attachment 8687137 [details]
[gaia] ferjm:bug1223668.followup > mozilla-b2g:master

Hi Carsten,

Could you please help to uplift this patch as well?

It's different from Eric's one in comment 14 and aims to fix the linter errors introduced by that one.

Thanks.

	Carsten Book [:Tomcat]
	Comment 18 • 9 years ago

(In reply to Luke Chang [:lchang] from comment #17)
> Comment on attachment 8687137 [details]
> [gaia] ferjm:bug1223668.followup > mozilla-b2g:master
> 
> Hi Carsten,
> 
> Could you please help to uplift this patch as well?
> 
> It's different from Eric's one in comment 14 and aims to fix the linter
> errors introduced by that one.
> 
> Thanks.

Hi Luke, no problem, pushed in https://github.com/mozilla-b2g/gaia/commit/50c5babe34fb2b055da34fdde6847aabffe73246

	Luke Chang [:lchang] (inactive)
	Comment 19 • 9 years ago

Carsten, Thanks a lot.