Closed Bug 12242 Opened 25 years ago Closed 25 years ago

patched file deleted after patch, if registry call fails in finalize

Categories

(Core Graveyard :: Installer: XPInstall Engine, defect, P3)

x86
Other
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: cathleennscp, Assigned: dveditz)

Details

if for some reason, your registry file (nsreg.dat) is corrupted, and you install a patch to patch files, your files will all be deleted. To reproduce (must have a corrupted registry): 1. trigger http://warp/u/cathleen/test/xpinstall/patch/install.jar to install a file in c:\patch\f1.txt 2. trigger http://warp/u/cathleen/test/xpinstall/patch/patch.jar to patch f1.txt 3. noticed that nothing is left in c:\patch We don't need to track the return value for VR_Install in nsInstallPatch::Complete() because it will cause abort,and in turn the file gets deleted. Patching is not a reversible process, if the registry update fails, we leave the patched/updated file.
Target Milestone: M10
I believe Dan has a simple fix for this on his machine.
Assignee: cathleen → dveditz
Dan, you got the fixes on your machine. Can you check them in?
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Build 1999-10-22-09-M11(WIN), 1999-10-21-09-M11(MAC), 1999-10-22-08-M11(LINUX) Files patch even if they can't get registered. Marking Verified.
Bulk move of XPInstall (component to be deleted) bugs to Installer: XPInstall Engine
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.