Closed
Bug 1224232
Opened 9 years ago
Closed 9 years ago
Refactor toolbar style to not calculate position of right toolbar
Categories
(DevTools :: Memory, defect, P3)
DevTools
Memory
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: jsantell, Unassigned)
References
(Blocks 1 open bug)
Details
Right now the toolbar-group in the toolbar (everything from the breakdown selector rightwards) is positioned based on the left part of the toolbar. This can change if "Import..." text in a button is > 78px, so L10N would probably affect this positioning.
Updated•9 years ago
|
Blocks: memory-frontend
Has STR: --- → irrelevant
Updated•9 years ago
|
Priority: -- → P3
Comment 1•9 years ago
|
||
We still do a small bit of calc()'ing but much less than before.
https://dxr.mozilla.org/mozilla-central/source/devtools/client/themes/memory.css#61
> .devtools-toolbar > .toolbar-group:nth-of-type(1) {
> /**
> * We want this to be exactly at a `--sidebar-width` distance from the
> * toolbar's start boundary. A `.devtools-toolbar` has a 3px start padding.
> */
> flex: 0 0 calc(var(--sidebar-width) - 3px);
> border-inline-end: 1px solid var(--theme-splitter-color);
> margin-inline-end: 5px;
> }
Do we still want to keep this bug open?
Flags: needinfo?(ntim.bugs)
Flags: needinfo?(jsantell)
Comment 2•9 years ago
|
||
This solution is fine for now, but we might want to change it depending on how we'll want to handle small widths (whether we want to show the sidebar on the top like the Style Editor/Storage Inspector, or whether we want to show it on the left like the perf tool).
But if the plan is to leave it as it is, the current code is fine.
Flags: needinfo?(ntim.bugs)
Comment 3•9 years ago
|
||
Ok, then we can file new bugs if/when that time comes.
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: needinfo?(jsantell)
Resolution: --- → WORKSFORME
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•