Closed Bug 1224278 Opened 9 years ago Closed 7 years ago

Hide client records that are likely to be duplicates or stale in Fennec Send to Device list

Categories

(Firefox for Android Graveyard :: Data Providers, defect)

defect
Not set
normal

Tracking

(firefox45 affected)

RESOLVED DUPLICATE of bug 1351104
Tracking Status
firefox45 --- affected

People

(Reporter: nalexander, Unassigned, Mentored)

References

Details

(Whiteboard: [lang=java][good next bug])

Bug 1180287 added some filtering to the list of clients displayed in the Synced Tabs panel. ckolos reports an issue: it looks like we missed adding that filtering to the Send Tab / Send to Device list. (I thought this would Just Work, but it may not.) This ticket tracks using the same query to populate the Send Tab dialog list as well.
Ahmed: can you investigate this? I've tracked the query back to https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/overlays/service/sharemethods/SendTab.java#258, which might need to be updated. Thanks!
Mentor: nalexander
Flags: needinfo?(ahmedibrahimkhali)
Whiteboard: [lang=java][good next bug]
I've had the devices in the Send Tab to Device list be filtered before but now it seems like it might be broken (i.e. afaik, I didn't change anything but my current device shows up as a duplicate in the device list).
Hi Nick, I'm pretty sure that the SendTab dialog displays the expected devices, actually while I was developing on Bug 1180287, I always made sure that it worked on the SendTab dialog first, then verified the code on the Synced Tabs Panel. I doubt that this issue is related to the filtering code in Bug 1180287. I checked also Fennec latest build, and both the Synced Tabs Panel and the SendTab dialog displays the same set of devices.
Flags: needinfo?(ahmedibrahimkhali)
Blocks: 1254391
Is this bug still valid, based on comment 3 above? If so, I'd like to take a stab at looking into it. I have a build that is ready to go and I've submitted 3 defects for code review recently.
We're doing some work to improve data behind this list, so duping this bug against a meta one.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.