Closed
Bug 1224289
Opened 9 years ago
Closed 9 years ago
add eslint rule to reject use of Cu.importGlobalProperties
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(firefox46 fixed)
RESOLVED
FIXED
Firefox 46
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: tromey, Assigned: tromey)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
miker
:
review+
|
Details | Diff | Splinter Review |
Cu.importGlobalProperties is dangerous to use and I'm removing
it from devtools in bug 1223452. It would be good to have a new
eslint rule to reject new uses of it.
Assignee: nobody → mratcliffe
Assignee: mratcliffe → nobody
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → ttromey
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•9 years ago
|
||
|
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8710533 [details] [diff] [review]
add eslint rule to reject Cu.importGlobalProperties
I enabled this for devtools only, since I don't know what other project want.
For devtools we've already eliminated all the calls to this from our code.
Attachment #8710533 -
Flags: review?(mratcliffe)
|
|
Assignee | |
Comment 3•9 years ago
|
||
Missed index.rst.
Attachment #8710533 -
Attachment is obsolete: true
Attachment #8710533 -
Flags: review?(mratcliffe)
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8710539 -
Flags: review?(mratcliffe)
Attachment #8710539 -
Flags: review?(mratcliffe) → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
|
||
Comment 6•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
|
||
Comment 7•9 years ago
|
||
[bugday-20160323]
Status: RESOLVED,FIXED -> UNVERIFIED
Comments:
STR: Not clear.
Developer specific testing
Component:
Name Firefox
Version 46.0b9
Build ID 20160322075646
Update Channel beta
User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS Windows 7 SP1 x86_64
Expected Results:
Developer specific testing
Actual Results:
As expected
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•