Closed
Bug 1224689
Opened 9 years ago
Closed 9 years ago
TEST-UNEXPECTED-FAIL | toolkit/components/places/tests/unifiedcomplete/test_remotetabmatches.js
Categories
(Thunderbird :: General, defect)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 45.0
People
(Reporter: mkmelin, Assigned: markh)
References
Details
(Keywords: intermittent-failure, regression)
Attachments
(1 file)
(deleted),
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
This is due to http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/components/places/tests/unifiedcomplete/test_remotetabmatches.js
... as thunderbird doesn't have services-sync.
Comment 1•9 years ago
|
||
Right. This test got implemented in bug 1210616 and landed 2015-11-12.
Why do we run this test for TB. This is a Firefox test, is it not?
Comment 2•9 years ago
|
||
(In reply to Jorg K (GMT+1) from comment #1)
> Right. This test got implemented in bug 1210616 and landed 2015-11-12.
> Why do we run this test for TB. This is a Firefox test, is it not?
Yes, the right thing to do is to disable this test for Thunderbird (with skip-if = appname == "thunderbird").
Comment 3•9 years ago
|
||
(In reply to aleth [:aleth] from comment #2)
> Yes, the right thing to do is to disable this test for Thunderbird (with
> skip-if = appname == "thunderbird").
(if there isn't something smarter along the lines of run-if = sync-enabled, that is)
Comment 4•9 years ago
|
||
Sorry for not catching that.
Maybe Mark knows a better way to detect if the product supports Sync and we could just skip in the test itself.
Flags: needinfo?(markh)
Assignee | ||
Comment 5•9 years ago
|
||
(In reply to Marco Bonardo [::mak] from comment #4)
> Sorry for not catching that.
>
> Maybe Mark knows a better way to detect if the product supports Sync and we
> could just skip in the test itself.
I think it makes sense to have a mozinfo variable for "sync" just as there already is for healthreporter, especially as there will probably be more sync work coming up that will hit the same problem. This simple patch adds a "sync" variable and a "skip-if = !sync" to that tests manifest entry.
Assignee: nobody → markh
Status: NEW → ASSIGNED
Flags: needinfo?(markh)
Attachment #8687730 -
Flags: review?(ted)
Reporter | ||
Comment 6•9 years ago
|
||
A bit off-topic, but is there a reason the variables aren't named the same as their originals (or lower-cased equivalents)? As in this case, why "sync" instead of "MOZ_SERVICES_SYNC".
Comment 7•9 years ago
|
||
Probably just accidental, I was originally matching the existing mozinfo variables (like `os`), but then it went farther than I expected.
Updated•9 years ago
|
Attachment #8687730 -
Flags: review?(ted) → review+
Comment 8•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f0c815f451f761c90634789b055090b8ea438187
Bug 1224689 - Add a 'sync' mozinfo variable and only run test_remotetabmatches.js if it is defined. r=ted
Updated•9 years ago
|
Target Milestone: --- → Thunderbird 45.0
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 9•9 years ago
|
||
bugherder |
You need to log in
before you can comment on or make changes to this bug.
Description
•