Now that we have the new mail notification showing up in the Windows System Tray, it would be cool if double clicking on it either opened mail or brought the 3 pane forward if it's already open. I'm not sure if it should just open the default mail account (or leave whatever is currently selected if a 3pane already exists), or if it should try to find one of the accounts that has mail. Probably the latter if possible.

triaging.

This change causes a double click on the biff icon to bring up the most recently used 3-pane window or create a new one (honoring your preferred 3-pane layout pref). I'm creating my own message window which receives the double click event from the window OS for this icon. This allowed me to remove a bad dependency I had on the hidden window since I now create my own.

Comment on attachment 67448 [details] [diff] [review] the fix This is only getting better. mscott, you rock ! r=bhuvan

Comment on attachment 67448 [details] [diff] [review] the fix sr=bienvenu

>This change causes a double click on the biff icon to bring up the most >recently used 3-pane window or create a new one (honoring your preferred 3-pane >layout pref). Great!

fixed.

I'm reopening because I'm using the 2/5 build on Win 2000 and nothing happens when I double click on the icon. For example, if I have the browser window on top and then double click on the new mail icon, nothing happens. It doesn't matter whether or not I have a mail window open.

strange this seems to work in debug builds. On release builds, when we try to give focus to the mail 3 pane, strange things are happening. If I have a browser window in front and i double click I can see focus changing and doing things within the browser window. Same thing if mail is in front. I can see selection go back to the mail window when i double click. If browser is in front, I see it re-highlight the text in the url bar as if it were being given focus.

I don't know if this patch will make double clicking the icon in release builds select the mail window or not. But for debug builds it now makes the focus smarter. If the mail window is iconfied (minimized) it will now open up the window and bring it to the front. If the mail window is behind another application (like Word or Quicken), it will now bring the mail window to the front.

well I've figured out why it's not working on optimized builds I just don't understand why =). The string: "mail:3pane" is getting optimized out as an empty string in this file when building optimized. things like: NS_LITERAL_STRING("mail:3pane").get() or nsCString foo ("mail:3pane") all have empty string values after the assignments.

The only way I could get the constant string "mail:3pane" to have any kind of value in WindowProc for optimized builds was to make it a static variable of my struct which gets initialized outside of the WindowProc routine. This patch includes that change + code to make sure the mail window steals focus from other applications (like word, etc.) when the user double clicks the icon. It also makes sure the mail window gets maximized if it's in a minimized state (iconified)

Comment on attachment 68941 [details] [diff] [review] the fix for optimized builds r=bhuvan

Comment on attachment 69115 [details] [diff] [review] the right patch (posted an older patch before) sr=bienvenu

fix checked in.

I've got Win9x, NT 4.0 and WinXP to verify the rest of this on, but so far: Windows 2000, build 2002-03-01-03 Tried with: * Mail closed totally * Mail running but browser focused * Both window types (alt and normal 3-pane). One thing I noticed, however, was that we auto-scroll to the new message if you have the window already open, but not if we just open the window (I think there is an existing bug about this, I'll check). Other platform verifications soon...

Verified this on windows 98 with build 2002-04-03-14. Verified FIXED.