Closed Bug 1225088 Opened 9 years ago Closed 9 years ago

[TV][2.5] Showing a content splash screen when content loading is slow

Categories

(Firefox OS Graveyard :: Gaia::TV, defect, P3)

ARM
Gonk (Firefox OS)
defect

Tracking

(blocking-b2g:2.5+, b2g-v2.5 verified, b2g-master verified)

RESOLVED FIXED
blocking-b2g 2.5+
Tracking Status
b2g-v2.5 --- verified
b2g-master --- verified

People

(Reporter: rickychien, Assigned: jyeh)

References

Details

(Whiteboard: [ft:conndevices][partner-cherry-pick])

Attachments

(2 files)

If the content is slow to load or install a splash screen is shown with the icon on of the content centered on a white background and below the icon a progress bar is displayed. When the content has finished loading the splash screen is dismissed and the content is shown. The user is able to press “back” on the remote to cancel loading the content and return to marketplace.
Whiteboard: [ft:conndevices][partner-cherry-pick]
Whiteboard: [ft:conndevices][partner-cherry-pick] → [ft:conndevices][partner-cherry-pick][partner-blocker]
Whiteboard: [ft:conndevices][partner-cherry-pick][partner-blocker] → [ft:conndevices][partner-cherry-pick]
Hi Josh, This feature should be descoped since marketplace is going to target on websites and hosted apps currently without packaged apps. Content loading should not be too slow when opening a website or hosted app. As a result, we prefer to move it as 2.6?
Assignee: rchien → nobody
Status: ASSIGNED → NEW
blocking-b2g: --- → 2.6?
Flags: needinfo?(jocheng)
(In reply to Ricky Chien [:rickychien] from comment #1) > Hi Josh, > > This feature should be descoped since marketplace is going to target on > websites and hosted apps currently without packaged apps. Content loading > should not be too slow when opening a website or hosted app. As a result, we > prefer to move it as 2.6? Agree, let's move this to 2.6. Thanks!
blocking-b2g: 2.6? → 2.6+
Flags: needinfo?(jocheng)
Hi Ricky, Could you provide ETA date if you can start the work now? Thanks
blocking-b2g: 2.6+ → 2.5?
Flags: needinfo?(rchien)
After offline discussion, this bug will not make the progress bar running in downloading / installing phase, instead it will start to detect the loading progress in preview content loading. I'll start the work right now and hope we can finish it this weekend.
Flags: needinfo?(rchien)
Finally, we decided to show up a spinning icon instead of progress bar because we are unable to detect assets loading progress inside an iframe. I'm going to investigate the implementation in preview_window.js and start the work once new visual spec comes out.
Assignee: nobody → rchien
Status: NEW → ASSIGNED
Assignee: rchien → jyeh
Comment on attachment 8724000 [details] [gaia] jostw:josyeh/Marketplace/master/Bug1225088 > mozilla-b2g:master Hi Luke, this patch will add a spinner and show it when launching the preview window. Please take a look at it, thanks!
Attachment #8724000 - Flags: review?(lchang)
Comment on attachment 8724000 [details] [gaia] jostw:josyeh/Marketplace/master/Bug1225088 > mozilla-b2g:master The "smart-spinner" is not a web component so you don't need to put it in the "bower_components" folder. Otherwise, you should add a repository to "fxos-components" [1] for that. [1] https://github.com/fxos-components
Attachment #8724000 - Flags: review?(lchang)
Comment on attachment 8724000 [details] [gaia] jostw:josyeh/Marketplace/master/Bug1225088 > mozilla-b2g:master Hi Luke, web component has removed. Thanks.
Attachment #8724000 - Flags: review?(lchang)
Comment on attachment 8724000 [details] [gaia] jostw:josyeh/Marketplace/master/Bug1225088 > mozilla-b2g:master It's almost done! Please alter it a bit per our discussion. Thanks.
Attachment #8724000 - Flags: review?(lchang)
blocking-b2g: 2.5? → 2.5+
Comment on attachment 8724000 [details] [gaia] jostw:josyeh/Marketplace/master/Bug1225088 > mozilla-b2g:master Hi Luke, splash screen is now a sub component of AppWindow. Thanks!
Attachment #8724000 - Flags: review?(lchang)
Comment on attachment 8724000 [details] [gaia] jostw:josyeh/Marketplace/master/Bug1225088 > mozilla-b2g:master Looks great! Thanks.
Attachment #8724000 - Flags: review?(lchang) → review+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment on attachment 8724000 [details] [gaia] jostw:josyeh/Marketplace/master/Bug1225088 > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): 1225088 [User impact] if declined: No splash screen when content loading is slow [Testing completed]: Yes [Risk to taking this patch] (and alternatives if risky): Low [String changes made]: No
Attachment #8724000 - Flags: approval-gaia-v2.5?(jocheng)
Comment on attachment 8724000 [details] [gaia] jostw:josyeh/Marketplace/master/Bug1225088 > mozilla-b2g:master Approve for TV 2.5
Attachment #8724000 - Flags: approval-gaia-v2.5?(jocheng) → approval-gaia-v2.5+
Verified this issue on v2.6 latest build and the spinning icon shows when launching a slow content in preview mode. [Build Info] 2.6 TV Simulator gaia: https://github.com/mozilla-b2g/gaia/commit/ae8fe4552de265860970162f1d199ec6326fc51d gecko: https://hg.mozilla.org/mozilla-central/rev/5a2e0878d6c258b36b0ee8712a2afcde6ad94c78
Hi Helen, do we have new version of visual spec here?
Flags: needinfo?(hhuang)
Blocks: 1253986
Status: RESOLVED → VERIFIED
Hi Tori, do we have new version of UX spec here?
Flags: needinfo?(tchen)
ni Peko. For some reason, Peko is the visual owner for Marketplace now and she will help to update the visual spec.
Flags: needinfo?(hhuang) → needinfo?(pchen)
Clear this ni. It will be updated in visual spec.
Flags: needinfo?(tchen)
Hi Please check the path as below for new visual spec https://drive.google.com/open?id=0B4K8q1qWmtAvUTJGTFA3c2xOb0k I changed progress bar to spinner. Thanks
Flags: needinfo?(pchen)
Reopen this bug for adding icon under the spinner.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Please file another bug to follow up (unless you want to backout this one first).
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
Please see follow up bug 1257767 for adding icon under the spinner.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: