Closed
Bug 1225088
Opened 9 years ago
Closed 9 years ago
[TV][2.5] Showing a content splash screen when content loading is slow
Categories
(Firefox OS Graveyard :: Gaia::TV, defect, P3)
Tracking
(blocking-b2g:2.5+, b2g-v2.5 verified, b2g-master verified)
RESOLVED
FIXED
blocking-b2g | 2.5+ |
People
(Reporter: rickychien, Assigned: jyeh)
References
Details
(Whiteboard: [ft:conndevices][partner-cherry-pick])
Attachments
(2 files)
(deleted),
text/x-github-pull-request
|
lchang
:
review+
jocheng
:
approval-gaia-v2.5+
|
Details |
(deleted),
text/x-github-pull-request
|
Details |
If the content is slow to load or install a splash screen is shown with the icon on of the content centered on a white background and below the icon a progress bar is displayed.
When the content has finished loading the splash screen is dismissed and the content is shown.
The user is able to press “back” on the remote to cancel loading the content and return to marketplace.
Updated•9 years ago
|
Whiteboard: [ft:conndevices][partner-cherry-pick]
Updated•9 years ago
|
Whiteboard: [ft:conndevices][partner-cherry-pick] → [ft:conndevices][partner-cherry-pick][partner-blocker]
Updated•9 years ago
|
Whiteboard: [ft:conndevices][partner-cherry-pick][partner-blocker] → [ft:conndevices][partner-cherry-pick]
Reporter | ||
Comment 1•9 years ago
|
||
Hi Josh,
This feature should be descoped since marketplace is going to target on websites and hosted apps currently without packaged apps. Content loading should not be too slow when opening a website or hosted app. As a result, we prefer to move it as 2.6?
Assignee: rchien → nobody
Status: ASSIGNED → NEW
blocking-b2g: --- → 2.6?
Flags: needinfo?(jocheng)
Comment 2•9 years ago
|
||
(In reply to Ricky Chien [:rickychien] from comment #1)
> Hi Josh,
>
> This feature should be descoped since marketplace is going to target on
> websites and hosted apps currently without packaged apps. Content loading
> should not be too slow when opening a website or hosted app. As a result, we
> prefer to move it as 2.6?
Agree, let's move this to 2.6. Thanks!
Comment 3•9 years ago
|
||
Hi Ricky,
Could you provide ETA date if you can start the work now?
Thanks
blocking-b2g: 2.6+ → 2.5?
Flags: needinfo?(rchien)
Reporter | ||
Comment 4•9 years ago
|
||
After offline discussion, this bug will not make the progress bar running in downloading / installing phase, instead it will start to detect the loading progress in preview content loading.
I'll start the work right now and hope we can finish it this weekend.
Flags: needinfo?(rchien)
Reporter | ||
Comment 5•9 years ago
|
||
Finally, we decided to show up a spinning icon instead of progress bar because we are unable to detect assets loading progress inside an iframe. I'm going to investigate the implementation in preview_window.js and start the work once new visual spec comes out.
Assignee: nobody → rchien
Status: NEW → ASSIGNED
Reporter | ||
Updated•9 years ago
|
Assignee: rchien → jyeh
Comment 6•9 years ago
|
||
Assignee | ||
Comment 7•9 years ago
|
||
Comment on attachment 8724000 [details]
[gaia] jostw:josyeh/Marketplace/master/Bug1225088 > mozilla-b2g:master
Hi Luke, this patch will add a spinner and show it when launching the preview window.
Please take a look at it, thanks!
Attachment #8724000 -
Flags: review?(lchang)
Comment 8•9 years ago
|
||
Comment on attachment 8724000 [details]
[gaia] jostw:josyeh/Marketplace/master/Bug1225088 > mozilla-b2g:master
The "smart-spinner" is not a web component so you don't need to put it in the "bower_components" folder. Otherwise, you should add a repository to "fxos-components" [1] for that.
[1] https://github.com/fxos-components
Attachment #8724000 -
Flags: review?(lchang)
Assignee | ||
Comment 9•9 years ago
|
||
Comment on attachment 8724000 [details]
[gaia] jostw:josyeh/Marketplace/master/Bug1225088 > mozilla-b2g:master
Hi Luke, web component has removed. Thanks.
Attachment #8724000 -
Flags: review?(lchang)
Comment 10•9 years ago
|
||
Comment on attachment 8724000 [details]
[gaia] jostw:josyeh/Marketplace/master/Bug1225088 > mozilla-b2g:master
It's almost done! Please alter it a bit per our discussion. Thanks.
Attachment #8724000 -
Flags: review?(lchang)
Updated•9 years ago
|
blocking-b2g: 2.5? → 2.5+
Assignee | ||
Comment 11•9 years ago
|
||
Comment on attachment 8724000 [details]
[gaia] jostw:josyeh/Marketplace/master/Bug1225088 > mozilla-b2g:master
Hi Luke, splash screen is now a sub component of AppWindow. Thanks!
Attachment #8724000 -
Flags: review?(lchang)
Comment 12•9 years ago
|
||
Comment on attachment 8724000 [details]
[gaia] jostw:josyeh/Marketplace/master/Bug1225088 > mozilla-b2g:master
Looks great! Thanks.
Attachment #8724000 -
Flags: review?(lchang) → review+
Assignee | ||
Comment 13•9 years ago
|
||
Landed in gaia master.
https://github.com/mozilla-b2g/gaia/commit/ae8fe4552de265860970162f1d199ec6326fc51d
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 14•9 years ago
|
||
Comment on attachment 8724000 [details]
[gaia] jostw:josyeh/Marketplace/master/Bug1225088 > mozilla-b2g:master
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 1225088
[User impact] if declined: No splash screen when content loading is slow
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]: No
Attachment #8724000 -
Flags: approval-gaia-v2.5?(jocheng)
Assignee | ||
Updated•9 years ago
|
status-b2g-v2.5:
--- → affected
status-b2g-master:
--- → fixed
Comment 15•9 years ago
|
||
Comment on attachment 8724000 [details]
[gaia] jostw:josyeh/Marketplace/master/Bug1225088 > mozilla-b2g:master
Approve for TV 2.5
Attachment #8724000 -
Flags: approval-gaia-v2.5?(jocheng) → approval-gaia-v2.5+
Comment 16•9 years ago
|
||
Verified this issue on v2.6 latest build and the spinning icon shows when launching a slow content in preview mode.
[Build Info]
2.6 TV Simulator
gaia:
https://github.com/mozilla-b2g/gaia/commit/ae8fe4552de265860970162f1d199ec6326fc51d
gecko:
https://hg.mozilla.org/mozilla-central/rev/5a2e0878d6c258b36b0ee8712a2afcde6ad94c78
Comment 17•9 years ago
|
||
Hi Helen, do we have new version of visual spec here?
Flags: needinfo?(hhuang)
Comment 18•9 years ago
|
||
Assignee | ||
Comment 19•9 years ago
|
||
Comment 20•9 years ago
|
||
Verified this issue on following build and the spinning icon shows properly when launching a slow content in preview mode.
[Build Info]
gaia:
https://github.com/mozilla-b2g/gaia/commit/f2ee71a3cffa6a536b8dc558e6c013d7595f9c2e
gecko:
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/55524f2fac552f8e3074bcf220a2d138f4ea3201
mulet:
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/9d519d3bedacb7f5ce467f4c6bef7ff55ff3b0f3
Status: RESOLVED → VERIFIED
Comment 22•9 years ago
|
||
Test case creation: https://moztrap.mozilla.org/manage/cases/?&pagenumber=1&pagesize=100&sortfield=created_on&sortdirection=desc&filter-id=17935&filter-id=18006
Flags: in-moztrap+
Comment 23•9 years ago
|
||
ni Peko. For some reason, Peko is the visual owner for Marketplace now and she will help to update the visual spec.
Flags: needinfo?(hhuang) → needinfo?(pchen)
Comment 25•9 years ago
|
||
Hi
Please check the path as below for new visual spec
https://drive.google.com/open?id=0B4K8q1qWmtAvUTJGTFA3c2xOb0k
I changed progress bar to spinner.
Thanks
Flags: needinfo?(pchen)
Assignee | ||
Comment 26•9 years ago
|
||
Reopen this bug for adding icon under the spinner.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Comment 27•9 years ago
|
||
Please file another bug to follow up (unless you want to backout this one first).
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 28•9 years ago
|
||
Please see follow up bug 1257767 for adding icon under the spinner.
You need to log in
before you can comment on or make changes to this bug.
Description
•