Environment: Nightly (45.0a1 11-15-2015) Device: Samsung Galaxy S6 Edge (Android 5.1.1) Steps to reproduce: 1. Install Nightly and tap on icon 2. From on-boarding screen tap on "Sign in to Nightly" Actual result: Sign in screen is displayed but the following issues occur in the URL-bar area: 1.Sign in screen's URL spills out of the URL bar 2.Tab tray cannot be accessed and it's icon is displayed as a overlay between tab counter and a microphone icon 3. Menu button icon is improperly displayed and has no valid response. Expected result: Sign in screen is correctly displayed with no graphical errors Please note that this issue occurs only on Phone devices, tested on Nexus tab 9 and Samsung Galaxy tab S2 and the issue could not be reproduced. For further details please check : https://www.youtube.com/watch?v=stODCddN_aY&feature=youtu.be

Chenxia, any idea what's going on here?

Hm, it looks like the urlbar is flashing into editing mode when closing first run, but since we're actually opening up a different page, there's some kind of race condition and we never exit editing mode - I bet this is a regression from bug 1215739. We probably are sharing the "finished with firstrun" method and shouldn't be.

If this is causing us grief, we should not be afraid to back out bug 1215739 until this is fixed.

Bug 1225092 - Improper behavior when accessing log in screen from on-boarding screen. r=ally

I tested this with the Sync panel, as well as our other modes of exiting first run (single screen, tapping on urlbar, tapping back, tapping "Start browsing" link). Once this bakes for a while, I'll either request uplift to aurora, or if it's considered too risky, request backout of bug 1215739 from aurora.

Comment on attachment 8690232 [details] MozReview Request: Bug 1225092 - Don't show keyboard on Welcome panel. r=mcomella https://reviewboard.mozilla.org/r/25809/#review23425 lgtm

Comment on attachment 8690232 [details] MozReview Request: Bug 1225092 - Don't show keyboard on Welcome panel. r=mcomella Approval Request Comment [Feature/regressing bug #]: bug 1215739 created a regression in Sync setup [User impact if declined]: Some users will see broken UI in the urlbar until they restart Firefox [Describe test coverage new/current, TreeHerder]: local testing [Risks and why]: low, adds an if check with logic - this is strictly better than the current version. [String/UUID change made/needed]: none Alternatively, we can back out bug 1215739 from aurora.

Mihai, could you please verify this issue is fixed as expected on the latest Nightly build? Thanks!

Comment on attachment 8690232 [details] MozReview Request: Bug 1225092 - Don't show keyboard on Welcome panel. r=mcomella Let's uplift to Aurora44. I have requested Mihai to verify the fix in case of any unexpected fallouts.

This issue was tested on the latest Nightly build (45.0a1 2015-11-25) on Samsung Galaxy s6 Edge (Android 5.1.1) and Alcatel One Touch (Android 4.1.2) On nightly, this issue seems to be fixed for the scenario in which at first run, the start up screen presents both IMPORT and SYNC menus. If the user selects SYNC and "Sign in to Nightly" the issue is not reproducible anymore. However in the case in which, at first run, the welcome screen is displayed and tapping on "Sign in to Nightly" the issue still reproduces on any phone device. In order to trigger different start-up screens please see bug 1199859 comm 24

Comment on attachment 8690232 [details] MozReview Request: Bug 1225092 - Don't show keyboard on Welcome panel. r=mcomella Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25809/diff/1-2/

I forgot to add the flag to the Welcome screen, which also goes to Sync signup.

Comment on attachment 8690232 [details] MozReview Request: Bug 1225092 - Don't show keyboard on Welcome panel. r=mcomella https://reviewboard.mozilla.org/r/25809/#review24215 Not the point of this change but `FirstrunPane.showBrowserHint` doesn't always show the browser hint so it's an unintuitive name.

Requesting approval for the second part of this bug - I missed one of the panels in the original fix. This change has been reviewed in the reviewboard request and is what's landed on Nightly, but I'm isolating the commit as a patch for simplicity. Approval Request Comment [Feature/regressing bug #]: bug 1215739 created a regression in Sync setup, and I forgot to include the fix for the other panel [User impact if declined]: Users who see the Welcome panel will see regressed UI [Describe test coverage new/current, TreeHerder]: local testing, same as what's in Nightly [Risks and why]: very low, add the fix for the other panel [String/UUID change made/needed]: none

Resetting the status-firefox44 flag given that the fix isn't complete without another patch uplift. See comment 20.

Mihai, could you please confirm this issue is fixed as expected on a latest Nightly build? Thanks!

Comment on attachment 8694960 [details] [diff] [review] welcome-fix One-liner, taking it. Aurora44+

Verified as fixed on the latest Nightly build 45.0a1 (2015-12-04). This issue was tested on a Xiaomi mi i4 phone with Android 5.0.2 and on a Nexus 6 with Android 6.0.

Verified based on comment 25

Verified as fixed in Firefox 44 Beta 2; Device: Nexus 5 (Android 6.0.1).