We change the default values when the tab passed to `setProperty` is null. This is only meant to happen for explicitly omitted tab IDs, but `TabManager.getTab` also returns null for invalid IDs.

Chrome sets lastError in these cases, so we're going to need to wait for bug 1190680. And we'll need to make sure lastError is cleared before and after entering any API functions, so we'll also need to wait for the binding layer in bug 1208257.

Review commit: https://reviewboard.mozilla.org/r/57766/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/57766/

Comment on attachment 8760039 [details] Bug 1225215: [webext] Raise the expected errors when given invalid tab IDs. https://reviewboard.mozilla.org/r/57766/#review54838 ::: browser/components/extensions/ext-tabs.js:835 (Diff revision 1) > move([tabA, tabB], {index: 0}) > -> tabA to 0, tabB to 0 if tabA and tabB are in different windows > */ > let indexMap = new Map(); > > - for (let tabId of tabIds) { > + let tabs = tabIds.map(tabId => TabManager.getTab(tabId, context)); Did you mean to get rid of the previous "ignore invalid tabs" behavior? ::: toolkit/components/extensions/ext-webNavigation.js:166 (Diff revision 1) > if (!tab) { > return Promise.reject({message: `No tab found with tabId: ${details.tabId}`}); > } i don't think this is reachable any more? ::: toolkit/components/extensions/ext-webNavigation.js:178 (Diff revision 1) > if (!tab) { > return Promise.reject({message: `No tab found with tabId: ${details.tabId}`}); > } same as above

https://reviewboard.mozilla.org/r/57766/#review54838 > Did you mean to get rid of the previous "ignore invalid tabs" behavior? Yeah. I never saw the point of that, and we didn't have a test for it, so I figured we may as well make the behavior consistent with the rest of the tab methods. > i don't think this is reachable any more? Oh, yeah.

https://hg.mozilla.org/integration/mozilla-inbound/rev/57c5749e5b19612638a3ab08027431e6346c538e Bug 1225215: [webext] Raise the expected errors when given invalid tab IDs. r=aswan

https://hg.mozilla.org/integration/mozilla-inbound/rev/231c74115211681d0a4b1692513fbb7f1d60a36a Bug 1225215: Follow-up: ESLint fix. r=me

https://hg.mozilla.org/mozilla-central/rev/57c5749e5b19 https://hg.mozilla.org/mozilla-central/rev/231c74115211