Closed
Bug 1225356
Opened 9 years ago
Closed 9 years ago
[TV][2.5] Showing app’s detail in the preview area when navigating to an app
Categories
(Marketplace Graveyard :: General, defect, P1)
Marketplace Graveyard
General
Tracking
(blocking-b2g:2.5+)
RESOLVED
FIXED
blocking-b2g | 2.5+ |
People
(Reporter: jyeh, Assigned: jyeh, Mentored)
References
Details
(Whiteboard: [ft:conndevices])
Attachments
(1 file, 1 obsolete file)
No description provided.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jyeh
Blocks: TV_Marketplace_2.5
Assignee | ||
Updated•9 years ago
|
Status: NEW → ASSIGNED
Updated•9 years ago
|
Priority: -- → P2
Assignee | ||
Comment 1•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8689314 -
Flags: review?(ehung)
Assignee | ||
Comment 2•9 years ago
|
||
I made three commits for this bug. Please review the commits with bug number 1225356 on it.
1. Create app preview area on top of app list.
2. Install spatial navigation from github, and make focusable when the page is loaded.
3. Update app preview area with the app's information when focus event is triggered.
Attachment #8689314 -
Attachment is obsolete: true
Attachment #8689314 -
Flags: review?(ehung)
Attachment #8689372 -
Flags: review?(ehung)
Comment 3•9 years ago
|
||
Comment on attachment 8689372 [details]
jostw:josyeh/Marketplace/master/Bug1225356 > mozilla-b2g:master
I reviewed the usage of spatial navigation and it looks good to me. For the rest part, need Marketplace frontend peer's review.
ni David and Lindsay to find a right person.
Flags: needinfo?(lsaunders)
Flags: needinfo?(ddurst)
Attachment #8689372 -
Flags: review?(ehung) → feedback+
Updated•9 years ago
|
Mentor: dspasovski
Flags: needinfo?(ddurst)
Updated•9 years ago
|
Flags: needinfo?(lsaunders)
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8689372 [details]
jostw:josyeh/Marketplace/master/Bug1225356 > mozilla-b2g:master
Hi Davor,
There are three commits for this bug (i.e. 65b47a1, 3fbc00f and 3fa7fe0) and I have described them at https://bugzilla.mozilla.org/show_bug.cgi?id=1225356#c2.
Can you help me reviewing this? Thanks!
Attachment #8689372 -
Flags: review?(dspasovski)
Assignee | ||
Comment 5•9 years ago
|
||
Little changes made at the last commit, hash changed from 3fa7fe0 to df09a4c.
Updated•9 years ago
|
blocking-b2g: --- → 2.5+
Updated•9 years ago
|
Whiteboard: [ft:conndevices]
Updated•9 years ago
|
Priority: P2 → P1
Comment 7•9 years ago
|
||
Comment on attachment 8689372 [details]
jostw:josyeh/Marketplace/master/Bug1225356 > mozilla-b2g:master
robberstamp r+ because spasovski gave his r+ on Github.
Attachment #8689372 -
Flags: review?(dspasovski) → review+
Assignee | ||
Comment 8•9 years ago
|
||
Landed in marketplace-tv-front-end master
https://github.com/mozilla-b2g/marketplace-tv-front-end/commit/a488ab3af80de7c518bf8f2596b8514c9d58296c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•