Alastor Wu [:alwu] Assignee
	Description • 9 years ago

When we seek the MediaElement, its AudioChannelAgent shouldn't be unregistered.

That is because we don't want the previous interrupted audio (if exists) is resumed during seeking the MediaElement. ex. bug1198165.

	Alastor Wu [:alwu] Assignee
	Comment 1 • 9 years ago

Hi, Baku,
Do we have similar test case for this situation?
Thanks!

	Andrea Marchesini [:baku]
	Comment 2 • 9 years ago

No test for it as far as I can see from bug 1048171.

	Alastor Wu [:alwu] Assignee
	Comment 3 • 9 years ago

Review commit: https://reviewboard.mozilla.org/r/29061/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29061/

	Alastor Wu [:alwu] Assignee
	Comment 4 • 9 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b3481b974e30

	Alastor Wu [:alwu] Assignee
	Comment 5 • 9 years ago

Comment on attachment 8701994 [details]
MozReview Request: Bug 1225425 - [Testcase] Do not unregister the AudioChannelAgent during seeking. r=baku.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29061/diff/1-2/

	Andrea Marchesini [:baku]
	Comment 6 • 9 years ago

Comment on attachment 8701994 [details]
MozReview Request: Bug 1225425 - [Testcase] Do not unregister the AudioChannelAgent during seeking. r=baku.

https://reviewboard.mozilla.org/r/29061/#review26341

	Alastor Wu [:alwu] Assignee
	Comment 7 • 9 years ago

Comment on attachment 8701994 [details]
MozReview Request: Bug 1225425 - [Testcase] Do not unregister the AudioChannelAgent during seeking. r=baku.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29061/diff/1-2/

	Alastor Wu [:alwu] Assignee
	Comment 8 • 9 years ago

Rebase.

	Pulsebot
	Comment 9 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/fc20ecea0409

	Nigel Babu [:nigelb]
	Comment 10 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/31c319b09ec07c21f7fe164aab728391cf6b8f38
Backed out changeset fc20ecea0409 (bug 1225425) for failing its own tests

	Nigel Babu [:nigelb]
	Comment 11 • 9 years ago

Busted M(1) across most platforms other than b2g-related ones like this:

https://treeherder.mozilla.org/logviewer.html#?job_id=19415137&repo=mozilla-inbound

	Alastor Wu [:alwu] Assignee
	Comment 12 • 9 years ago

Comment on attachment 8701994 [details]
MozReview Request: Bug 1225425 - [Testcase] Do not unregister the AudioChannelAgent during seeking. r=baku.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29061/diff/2-3/

	Alastor Wu [:alwu] Assignee
	Comment 13 • 9 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4c8f2997a4e3

	Alastor Wu [:alwu] Assignee
	Comment 14 • 9 years ago

Comment on attachment 8701994 [details]
MozReview Request: Bug 1225425 - [Testcase] Do not unregister the AudioChannelAgent during seeking. r=baku.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29061/diff/3-4/

	Alastor Wu [:alwu] Assignee
	Comment 15 • 9 years ago

In following try-server result, this patch can pass most of tests, except some test case fails.
However, these orange lights are also seen in other people's try. 
I think that might not be caused by my patch.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=24f349ade22a&selectedJob=15215247

	Alastor Wu [:alwu] Assignee
	Comment 16 • 9 years ago

Comment on attachment 8701994 [details]
MozReview Request: Bug 1225425 - [Testcase] Do not unregister the AudioChannelAgent during seeking. r=baku.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29061/diff/4-5/

	Pulsebot
	Comment 17 • 9 years ago

https://hg.mozilla.org/integration/b2g-inbound/rev/783fc5968e65

	Carsten Book [:Tomcat]
	Comment 18 • 9 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/783fc5968e65