Open Bug 1225531 Opened 9 years ago Updated 2 years ago

In JS::ubi::DominatorTree, track predecessors with a single vector and indices, rather than vector of vectors

Categories

(Core :: JavaScript Engine, defect)

defect

Tracking

()

People

(Reporter: fitzgen, Unassigned)

References

(Blocks 2 open bugs)

Details

(In reply to Steve Fink [:sfink, :s:] from bug 961329 comment #26) > Ok, I'm just twiddling things here, but does this really require a Vector of > Vectors? Would it complicate things too much to count the total number of > predecessors when building the predecessor sets, then use a single Vector of > the right size where node i's predecessors are stored at indexes v[i] .. > v[i+1]-1? (So you'd have a initial size-N section giving start indexes for > predecessors for each node, then the predecessors themselves packed tight.) > It's an abuse of the type system (it's conceptually a Vector of Vectors, > only instead of storing N <length,separately alloced array> pairs you'd > dangerously typelessly encode them into a flat vector of 32- or 64-bit > ints.) But I always think of heap graphs as *huge*, so I'm paranoid about > space.
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Assignee: nfitzgerald → nobody
Status: ASSIGNED → NEW
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.