While adding tests I realised we don't handle the case where a non-existent variable is exported. The patch fixes this by adding a check to ModuleBuilder::buildAndInit(). I also renamed that class' methods appendLocalExportEntry() and appendIndirectExportEntry() which both append to exportEntries_ rather than localExportEntries_ and indirectExportEntries_ which might be been expected given the names, and added a new appendLocalExportEntry() which does append to localExportEntries_ after doing the check.

Comment on attachment 8688564 [details] [diff] [review] check-unbound-local-exports Review of attachment 8688564 [details] [diff] [review]: ----------------------------------------------------------------- Oops, good catch. ::: js/src/builtin/ModuleObject.cpp @@ +993,4 @@ > importEntries, > localExportEntries, > indirectExportEntries, > starExportEntries); Nit: re-line up the rest of the arguments.