Closed
Bug 1225703
Opened 9 years ago
Closed 9 years ago
Update in-tree libcubeb
Categories
(Core :: Audio/Video: cubeb, defect)
Core
Audio/Video: cubeb
Tracking
()
RESOLVED
FIXED
mozilla45
Tracking | Status | |
---|---|---|
firefox45 | --- | fixed |
People
(Reporter: kinetik, Assigned: kinetik)
References
Details
Attachments
(1 file)
(deleted),
patch
|
padenot
:
review+
|
Details | Diff | Splinter Review |
Update out in-tree libcubeb to bring in the device enumeration changes and whatever else has changed since the last update.
I've synced several changes to the Gecko version back to the upstream cubeb, but this is becoming a major pain because these changes are being made without my awareness and it is VERY easy to accidentally revert changes when changes are made in both locations.
Some of the changes don't even make sense for third-party code, such as the ScopedXPCOM guff added in bug 1219480.
So, from here on out, changes must be upstreamed into libcubeb and then updated into Gecko using the update script.
Assignee | ||
Comment 1•9 years ago
|
||
CC :rillian, see above comment re bug 1219480 changes.
Comment hidden (obsolete) |
Comment hidden (obsolete) |
Comment hidden (obsolete) |
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → kinetik
Status: NEW → ASSIGNED
Comment hidden (obsolete) |
Assignee | ||
Comment 6•9 years ago
|
||
Assignee | ||
Comment 7•9 years ago
|
||
Attachment #8689860 -
Flags: review?(padenot)
Comment 8•9 years ago
|
||
Comment on attachment 8689860 [details] [diff] [review]
v0
Review of attachment 8689860 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks.
Attachment #8689860 -
Flags: review?(padenot) → review+
Assignee | ||
Comment 9•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f51676191a6be10a6321edd49662a73a21e381d
Bug 1225703 - Update in-tree libcubeb. r=padenot
I had to back this out for windows cpp unittest failures: https://treeherder.mozilla.org/logviewer.html#?job_id=17666540&repo=mozilla-inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/042f728628d1
Flags: needinfo?(kinetik)
Assignee | ||
Comment 12•9 years ago
|
||
Sorry, obviously missed that failure in the try runs.
This is caused by 09b3e5e4, which made the WASAPI backend reject streams with a format other than CUBEB_SAMPLE_FLOAT32NE (because it never supported them). test_audio and test_sanity try to open streams with CUBEB_SAMPLE_S16LE.
Flags: needinfo?(kinetik)
Assignee | ||
Comment 13•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8631caf756eb6abf821a15a57a095a98d6f23af5
Bug 1225703 - Update in-tree libcubeb. r=padenot
Comment 14•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/48139ac411625d1ee8b21c51770b917502dba1d9
Backed out changeset 8631caf756eb (bug 1225703) for Cpp bustage on OS X 10.10 debug
Comment 15•9 years ago
|
||
Backed out for bustages like https://treeherder.mozilla.org/logviewer.html#?job_id=17919677&repo=mozilla-inbound on OS X 10.10 (both opt and debug, unlike what what the commit message claims)
Assignee | ||
Comment 16•9 years ago
|
||
Assignee | ||
Comment 17•9 years ago
|
||
(In reply to Nigel Babu [:nigelb] from comment #15)
> Backed out for bustages like
> https://treeherder.mozilla.org/logviewer.html#?job_id=17919677&repo=mozilla-
> inbound on OS X 10.10 (both opt and debug, unlike what what the commit
> message claims)
For some reason the Cpp tests didn't run on 10.10 for my Try push so I didn't catch this. Reproduced, fixed, and tested on a local 10.11 machine, so should be fine this time around.
Assignee | ||
Comment 18•9 years ago
|
||
Assignee | ||
Comment 19•9 years ago
|
||
(In reply to Matthew Gregan [:kinetik] from comment #18)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=7c23c3ac6ff9
This is with (just) 10.10 enabled.
Assignee | ||
Comment 20•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ce50ce20308c66be2772a856d10c00c99c83d4af
Bug 1225703 - Update in-tree libcubeb. r=padenot
Comment 21•9 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in
before you can comment on or make changes to this bug.
Description
•