Closed
Bug 1225827
Opened 9 years ago
Closed 9 years ago
WYSIWYG editor doesn't follow language dependent text-transform rules
Categories
(Webtools Graveyard :: Pontoon, defect, P3)
Webtools Graveyard
Pontoon
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: selim, Assigned: jotes, Mentored)
References
Details
Pontoon's web-bases translation editor doesn't follow text-transform rules for Turkish. Setting a lang=tr attribute should fix fix this.
See bug 231162 for the related discussion.
Updated•9 years ago
|
Priority: -- → P3
Comment 1•9 years ago
|
||
Setting a language attribute using javascript would work ? What about rtl languages like Arabic (ar)
document.documentElement.lang = 'tr'
How do I test if the text-transform rules are followed after testing this out ? and when should this change in lang attribute be made ?
Comment 2•9 years ago
|
||
My understanding is that each element we translate in-place should have lang attribute set to whatever language we translate to, just like we do in the textarea in the sidebar.
Selim, could you confirm this before we start digging into implementation details?
Flags: needinfo?(selim)
Comment 4•9 years ago
|
||
OK, so we should set lang attribute to locale code whenever an element is being edited in place or saved.
We should also set dir attribute on these elements (to "auto"), which is bug 1161687 and can be fixed in a separate PR.
Updated•9 years ago
|
Mentor: m
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jot
Comment 5•9 years ago
|
||
Commits pushed to master at https://github.com/mozilla/pontoon
https://github.com/mozilla/pontoon/commit/8450d831df106a540fa910967e5cda57ab1bfd37
Fix bug 1225827. Set the lang and dir attributes on editable elements.
https://github.com/mozilla/pontoon/commit/7a3986063fb1b887a64dde5bf30108b7ad471064
Merge pull request #357 from jotes/bug_1225827_follow_language_dependent_text_transform_rules
Fix bug 1225827. Set the lang and dir attributes on editable elements.
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•3 years ago
|
Product: Webtools → Webtools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•