Closed
Bug 1225847
Opened 9 years ago
Closed 9 years ago
[TV] Smart-Home FTE, part 2
Categories
(Firefox OS Graveyard :: Gaia::First Time Experience, defect, P2)
Firefox OS Graveyard
Gaia::First Time Experience
ARM
Gonk (Firefox OS)
Tracking
(blocking-b2g:2.5+, feature-b2g:2.5+, b2g-v2.5 fixed, b2g-master fixed)
RESOLVED
FIXED
People
(Reporter: rexboy, Assigned: rexboy)
References
Details
(Whiteboard: [ft:conndevices][partner-cherry-pick])
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
yifan
:
review+
jocheng
:
approval-gaia-v2.5+
|
Details |
We need to add the second page of first-time use for smart-home. Refer to spec: https://drive.google.com/folderview?id=0B4K8q1qWmtAvdUJFYUx5NFBEaVk&usp=sharing&tid=0B2-G3kew1WpXLURNc29vTWl5eUk Also the page.1 picture need to be updated for removing the browser icon.
Assignee | ||
Updated•9 years ago
|
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → rexboy
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8689958 [details]
[gaia] rexboy7:1225847-fte-home-part-2 > mozilla-b2g:master
Hi Yifan,
based on the updated visual, I added FTE page2 for smart-home. Fortunately no javascript changes needed (But I added some comments for necessary styles for FTEWizard)
Can you help review it?
Attachment #8689958 -
Flags: review?(yliao)
Updated•9 years ago
|
feature-b2g: --- → 2.5+
Updated•9 years ago
|
Status: NEW → ASSIGNED
Updated•9 years ago
|
QA Whiteboard: [COM=TV FTU]
Comment 3•9 years ago
|
||
Comment on attachment 8689958 [details]
[gaia] rexboy7:1225847-fte-home-part-2 > mozilla-b2g:master
LGTM! Thanks!
Attachment #8689958 -
Flags: review?(yliao) → review+
Assignee | ||
Comment 4•9 years ago
|
||
master https://github.com/mozilla-b2g/gaia/commit/874f626cbfb5e7dbc59ddb51069975ebfd2c8fe9
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8689958 [details]
[gaia] rexboy7:1225847-fte-home-part-2 > mozilla-b2g:master
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): feature
[User impact] if declined: FTE page of smart-home doesn't show on first time.
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky): small
[String changes made]: yes
Attachment #8689958 -
Flags: approval-gaia-v2.5?
Updated•9 years ago
|
Comment 6•9 years ago
|
||
Comment on attachment 8689958 [details]
[gaia] rexboy7:1225847-fte-home-part-2 > mozilla-b2g:master
Approve for TV 2.5 Smart-Home FTE
Attachment #8689958 -
Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
Comment 7•9 years ago
|
||
for 2.5 https://github.com/mozilla-b2g/gaia/commit/a42a4a9a272a14c0164cc4de0594f141c727a97c
You need to log in
before you can comment on or make changes to this bug.
Description
•