Closed Bug 1227144 Opened 9 years ago Closed 9 years ago

Use normal rooting for RegExpStatics

Categories

(Core :: JavaScript: GC, defect)

Product:
Core
Component:
JavaScript: GC
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla46
Tracking Flags:
Tracking Status
firefox45 --- affected
firefox46 --- fixed

People

(Reporter: terrence, Assigned: terrence)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

rooted_PreserveRegExpStatics-v0.diff
(deleted), patch
jonco
: review+
Details | Diff | Splinter Review
This is a CustomAutoRooter with what seems to be a copy-and-paste of RegExpStatics::trace.
Attachment #8690833 - Flags: review?(jcoppeard)
Comment on attachment 8690833 [details] [diff] [review] rooted_PreserveRegExpStatics-v0.diff Review of attachment 8690833 [details] [diff] [review]: ----------------------------------------------------------------- Nice.
Attachment #8690833 - Flags: review?(jcoppeard) → review+
Summary: Use normal rooting to for RegExpStatics → Use normal rooting for RegExpStatics
https://hg.mozilla.org/mozilla-central/rev/6d8293bceabf
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Are we missing a landing in this bug? It looks like PreserveRegExpStatics should still be using AutoRegExpStaticsBuffer after the backout.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: