arni2033 Reporter
	Description • 9 years ago

>>>   My Info:   Win7_64, Nightly 45, 32bit, ID 20151120030227
STR:
1. Open about:addons, set Flash to "Always activate"
2. Open "testcase 1" in a new window
3. Open   https://yandex.ru/search/?text=asdf   in another tab in that window
4. If flash isn't working on that site, click plugin icon in urlbar, then click "Allow and remember"
5. Switch to the tab from Step 2
6. Switch to the tab from Step 3

Result:       
 Flash content appears on top of "yandex.ru"

Expectations: 
 Flash content should hide when I switch to another tab

	arni2033 Reporter
	Comment 2 • 9 years ago

I'm not sure whether I should set this keyword, but content on "yandex.ru" site seems unstable.

When I save the page with search results, replace some links from [src="//...something"] to [src="https://...something"], open saved page in the browser and disable JS in devtools, it exposes the same issue. But that seems unreliable to me, because if I copy-paste the same .html file and open it in browser, it does not expose the issue.

	Jim Mathies [:jimm] Assignee
	Comment 3 • 9 years ago

hmph, today I can't reproduce.

	arni2033 Reporter
	Comment 4 • 9 years ago

(In reply to Jim Mathies [:jimm] from comment #3)
> hmph, today I can't reproduce.
Do you mean that you managed to do that earlier? Try refreshing the yandex page with Ctrl+Shift+R
I just reproduced it on a clear profile on latest Nightly using old testcase and yandex page.

	Jim Mathies [:jimm] Assignee
	Comment 5 • 9 years ago

This seems somewhat random. Sometimes I see it sometimes I don't. So fare only in a nightly build, I haven't had any luck reproducing in a local build.

	Jim Mathies [:jimm] Assignee
	Comment 6 • 9 years ago

(In reply to arni2033 from comment #4)
> (In reply to Jim Mathies [:jimm] from comment #3)
> > hmph, today I can't reproduce.
> Do you mean that you managed to do that earlier? Try refreshing the yandex
> page with Ctrl+Shift+R
> I just reproduced it on a clear profile on latest Nightly using old testcase
> and yandex page.

I'm testing using your data url and this bug page. I'll try the yandex page.

	Jim Mathies [:jimm] Assignee
	Comment 7 • 9 years ago

ok, I have this reproducing in a local build now.

	Jim Mathies [:jimm] Assignee
	Comment 9 • 9 years ago

Bug 1227666 - Insure that cached plugin geometry configuration cached in ShadowLayerForwarder gets cleared when we reflow and new content has no plugins. r?roc

	Jim Mathies [:jimm] Assignee
	Comment 10 • 9 years ago

mPluginWindowData needs to be cleared when content reflows and there are no plugins in the page. Otherwise that cache sticks around, and we can get window id collisions in the cached data with new plugins that get created. The yandex content is good at triggering this because it quickly creates and destroys plugins early during page load.

	Jim Mathies [:jimm] Assignee
	Comment 11 • 9 years ago

Comment on attachment 8692072 [details]
MozReview Request: Bug 1227666 - Insure that cached plugin geometry configuration cached in ShadowLayerForwarder gets cleared when we reflow and new content has no plugins. r?roc

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/26223/diff/1-2/

	Jim Mathies [:jimm] Assignee
	Comment 12 • 9 years ago

(In reply to Jim Mathies [:jimm] from comment #11)
> Comment on attachment 8692072 [details]
> MozReview Request: Bug 1227666 - Insure that cached plugin geometry
> configuration cached in ShadowLayerForwarder gets cleared when we reflow and
> new content has no plugins. r?roc
> 
> Review request updated; see interdiff:
> https://reviewboard.mozilla.org/r/26223/diff/1-2/

^ comment update

	Robert O'Callahan (:roc) (email my personal email if necessary)
	Comment 13 • 9 years ago

Comment on attachment 8692072 [details]
MozReview Request: Bug 1227666 - Insure that cached plugin geometry configuration cached in ShadowLayerForwarder gets cleared when we reflow and new content has no plugins. r?roc

https://reviewboard.mozilla.org/r/26223/#review23633

	Jim Mathies [:jimm] Assignee
	Comment 14 • 9 years ago

Thanks!

	Robert O'Callahan (:roc) (email my personal email if necessary)
	Comment 15 • 9 years ago

https://reviewboard.mozilla.org/r/26223/#review23637

	Pulsebot
	Comment 16 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/7c9da18db90c

	Carsten Book [:Tomcat]
	Comment 17 • 9 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/7c9da18db90c

	Jim Mathies [:jimm] Assignee
	Comment 18 • 9 years ago

Comment on attachment 8692072 [details]
MozReview Request: Bug 1227666 - Insure that cached plugin geometry configuration cached in ShadowLayerForwarder gets cleared when we reflow and new content has no plugins. r?roc

Approval Request Comment
[Feature/regressing bug #]:
plugin related
[User impact if declined]:
serious tab switching bug related to windowed plugins - when switching tabs some plugin windows may 'stick around' after the tab switch.
[Describe test coverage new/current, TreeHerder]:
just landed on mc.
[Risks and why]:
very low, well understood area of the code, well understood cause.
[String/UUID change made/needed]:
none

	Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)
	Comment 19 • 9 years ago

arni2033, could you please verify that this issue is fixed as expected on a latest Nightly build? Thanks!

	Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)
	Comment 20 • 9 years ago

Comment on attachment 8692072 [details]
MozReview Request: Bug 1227666 - Insure that cached plugin geometry configuration cached in ShadowLayerForwarder gets cleared when we reflow and new content has no plugins. r?roc

Serious regression and fix has been on Nightly for a few days, seems safe to uplift to Aurora44.

	Carsten Book [:Tomcat]
	Comment 21 • 9 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-aurora/rev/444d8d6198d2

	arni2033 Reporter
	Comment 22 • 9 years ago

(In reply to Ritu Kothari (:ritu) from comment #19)
> arni2033, could you please verify that this issue is fixed as expected on a latest Nightly build?
Yes, I don't see this happening with normal tab switching. 
>>>   My Info:   Win7_64, Nightly 45, 32bit, ID 20151201030226

However, sometimes plugins are displayed on top of wrong web pages if I switch tabs fast enough.
I filed bug 1229429. That happens to all pages, not only yandex, so I think that's a different case.
And probably the work in this bug was useless :(   I hope it's not.

	Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)
	Comment 23 • 9 years ago

(In reply to arni2033 from comment #22)
> (In reply to Ritu Kothari (:ritu) from comment #19)
> > arni2033, could you please verify that this issue is fixed as expected on a latest Nightly build?
> Yes, I don't see this happening with normal tab switching. 
> >>>   My Info:   Win7_64, Nightly 45, 32bit, ID 20151201030226
> 
> However, sometimes plugins are displayed on top of wrong web pages if I
> switch tabs fast enough.
> I filed bug 1229429. That happens to all pages, not only yandex, so I think
> that's a different case.
> And probably the work in this bug was useless :(   I hope it's not.

Thanks for the verification and I see that e10s team has triaged bug 1229429 and will hopefully have a fix ready soon.

	Carsten Book [:Tomcat]
	Comment 24 • 9 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/444d8d6198d2