The name is not intuitive and hard to remember. We should find a good name.

How about "PresentationControlService" since this class implements both client and server of control protocol?

(In reply to Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz) from comment #1) > How about "PresentationControlService" since this class implements both > client and server of control protocol? This is better than the original name.

Review commit: https://reviewboard.mozilla.org/r/54176/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/54176/

summary of the changes: 1. rename TCPPresentationServer.js to PresentationControlService.js 2. rename nsITCPPresentationServer to nsIPresentationControlServer 3. rename nsITCPPresentationServerListener to nsIPresentationControlServerListener (not 'Service' because those events are for server side only) 4. rename startService to startServer 5. change TCP_PRESENTATION_SERVER_CONTRACT_ID to PRESENTATION_CONTROL_SERVICE_CONTRACT_ID, and also change the string to "@mozilla.org/presentation/control-service;1" 6. rename variable names like 'presentationServer' to 'presentationService' 7. update log message and comments

We need to rename it on both TV2.6 branch and m-c to reduce future uplift effort.

Comment on attachment 8754687 [details] MozReview Request: Bug 1228266 - rename TCPPresentationServer to PresentationControlService. r=junior. https://reviewboard.mozilla.org/r/54176/#review50886 Looks good to me

Comment on attachment 8754687 [details] MozReview Request: Bug 1228266 - rename TCPPresentationServer to PresentationControlService. r=junior. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54176/diff/1-2/

(In reply to Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz) from comment #7) > Comment on attachment 8754687 [details] > MozReview Request: Bug 1228266 - rename TCPPresentationServer to > PresentationControlService. r=junior. > > Review request updated; see interdiff: > https://reviewboard.mozilla.org/r/54176/diff/1-2/ update for missing package-manifest.in changes.

Comment on attachment 8754687 [details] MozReview Request: Bug 1228266 - rename TCPPresentationServer to PresentationControlService. r=junior. NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] Bug caused by (feature/regressing bug #): Presentation API User impact if declined: n/a Testing completed: with automation test Risk to taking this patch (and alternatives if risky): no risk String or UUID changes made by this patch: n/a

Comment on attachment 8754687 [details] MozReview Request: Bug 1228266 - rename TCPPresentationServer to PresentationControlService. r=junior. Approve for TV 2.6

tv 2.6 patch is ready.