STR: - Download a Linux buildbot build. - Unpack it, start it. - Open about:config - Search for general.useragent.locale - See that the value is en-US - Download a Linux taskcluster build (on try, because all the links I try on inbound give me a "Artifact not found" error). - Unpack it, start it. - Open about:config - Search for general.useragent.locale - See that the value is x-test This is all due to the use of MOZ_SIMPLE_PACKAGE_NAME, which triggers this snippet: ifdef MOZ_SIMPLE_PACKAGE_NAME PKG_BASENAME := $(MOZ_SIMPLE_PACKAGE_NAME) else PKG_BASENAME = $(MOZ_PKG_APPNAME)-$(MOZ_PKG_VERSION).$(AB_CD).$(MOZ_PKG_PLATFORM) endif Note how the PKG_BASENAME when MOZ_SIMPLE_PACKAGE_NAME is not set has AB_CD in it, which is the locale. When l10n-check runs, which does a test repack, without MOZ_SIMPLE_PACKAGE_NAME, the en-US build is not overwritten since the filename for that test repack contains x-test instead of en-US. But with MOZ_SIMPLE_PACKAGE_NAME, l10n-check ends up overwriting target.tar.bz2, which leads to artifacts containing that test repack instead of the actual build.

See also: https://bugzilla.mozilla.org/show_bug.cgi?id=1203573#c9

Could we not simply fix l10n-check to not overwrite the existing build?

Comment on attachment 8692688 [details] [diff] [review] Avoid l10n-check overwriting final package when MOZ_SIMPLE_PACKAGE_NAME is set Review of attachment 8692688 [details] [diff] [review]: ----------------------------------------------------------------- Simple but effective.