Closed
Bug 1228929
Opened 9 years ago
Closed 9 years ago
[TV] Seperate the Send-to-TV offline content from the iframe
Categories
(Firefox OS Graveyard :: Gaia::First Time Experience, defect, P2)
Firefox OS Graveyard
Gaia::First Time Experience
ARM
Gonk (Firefox OS)
Tracking
(blocking-b2g:2.5+, b2g-v2.5 fixed, b2g-master fixed)
RESOLVED
FIXED
blocking-b2g | 2.5+ |
People
(Reporter: Fischer, Assigned: Fischer)
References
Details
(Whiteboard: [ft:conndevices][partner-blocker][partner-cherry-pick])
Attachments
(2 files)
(deleted),
text/x-github-pull-request
|
jocheng
:
approval-gaia-v2.5+
|
Details |
(deleted),
text/x-github-pull-request
|
rexboy
:
review+
|
Details |
In the simulator, the document.registerElement method is not available inside iframe so smart-button's function will not work. We have to separate the offline content from the iframe to let smart-button work as expected. p.s For the online content, we also have to watch this issue. The bug 1228927 is for tracking this issue for the online content.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → fliu
Assignee | ||
Comment 1•9 years ago
|
||
[Blocking Requested - why for this release]:
blocking-b2g: --- → 2.5?
Comment 2•9 years ago
|
||
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8693451 -
Flags: review?(rexboy)
Comment 4•9 years ago
|
||
Comment on attachment 8693451 [details]
PR #33437
r=me with some comments. Please make corresponding change before landing.
Attachment #8693451 -
Flags: review?(rexboy) → review+
Assignee | ||
Comment 5•9 years ago
|
||
Land to Master: https://github.com/Fischer-L/gaia/commit/bd5d06143eff25ae84fc586b4e74a8c472d4de6b Test: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=bd5d06143eff25ae84fc586b4e74a8c472d4de6b
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 6•9 years ago
|
||
Comment on attachment 8693450 [details]
[gaia] Fischer-L:bug_1228929-separate-offline-content-from-iframe > mozilla-b2g:master
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 1228929
[User impact] if declined: Button won't react to user's key input
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]: Yes
Attachment #8693450 -
Flags: approval-gaia-v2.5?
Assignee | ||
Comment 7•9 years ago
|
||
@Josh, This patch should be uplifted to the 2.5 as well, thank you.
Flags: needinfo?(jocheng)
Updated•9 years ago
|
blocking-b2g: 2.5? → 2.5+
Flags: needinfo?(jocheng)
Comment 8•9 years ago
|
||
Comment on attachment 8693450 [details]
[gaia] Fischer-L:bug_1228929-separate-offline-content-from-iframe > mozilla-b2g:master
Approve for TV 2.5
Attachment #8693450 -
Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
Comment 9•9 years ago
|
||
for 2.5 https://github.com/mozilla-b2g/gaia/commit/2d54c29f429bed790b5d8284633812dc2b782518
status-b2g-v2.5:
--- → fixed
status-b2g-master:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•