Closed
Bug 1229279
Opened 9 years ago
Closed 9 years ago
Use SourcePaths for FINAL_TARGET{_PP}_FILES
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox45 fixed)
RESOLVED
FIXED
mozilla45
Tracking | Status | |
---|---|---|
firefox45 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(2 files)
(deleted),
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8694108 -
Flags: review?(gps)
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8694110 -
Flags: review?(gps)
Comment 3•9 years ago
|
||
Comment on attachment 8694110 [details] [diff] [review]
Use mozbuild.context.Path for FINAL_TARGET{_PP}_FILES
Review of attachment 8694110 [details] [diff] [review]:
-----------------------------------------------------------------
::: python/mozbuild/mozbuild/frontend/context.py
@@ +525,5 @@
> @memoize
> def ContextDerivedTypedHierarchicalStringList(type):
> """Specialized HierarchicalStringList for use with ContextDerivedValue
> types."""
> + class _TypedListWithItems(ContextDerivedValue, HierarchicalStringList):
I assume this change wants to be in the other patch.
Assignee | ||
Comment 4•9 years ago
|
||
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #3)
> > + class _TypedListWithItems(ContextDerivedValue, HierarchicalStringList):
>
> I assume this change wants to be in the other patch.
Err, indeed.
Updated•9 years ago
|
Attachment #8694108 -
Flags: review?(gps) → review+
Updated•9 years ago
|
Attachment #8694110 -
Flags: review?(gps) → review+
Comment 6•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a5ae16d95a90
https://hg.mozilla.org/mozilla-central/rev/03b626d4e9a2
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•