Closed
Bug 1229328
Opened 9 years ago
Closed 9 years ago
Remove preprocessing from toolbox-window.xul
Categories
(DevTools :: Framework, defect)
DevTools
Framework
Tracking
(firefox45 fixed)
RESOLVED
FIXED
Firefox 45
Tracking | Status | |
---|---|---|
firefox45 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
bgrins
:
review+
|
Details | Diff | Splinter Review |
This prevent toolbox as window to work when using the live-reload addon from bug 1225108.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8694132 -
Flags: review?(bgrinstead)
Assignee | ||
Comment 2•9 years ago
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8694132 [details] [diff] [review]
patch v1
Review of attachment 8694132 [details] [diff] [review]:
-----------------------------------------------------------------
::: devtools/client/framework/toolbox-window.xul
@@ +27,5 @@
> command="toolbox-cmd-close"
> modifiers="accel"/>
> <key id="toolbox-key-toggle"
> key="&toggleToolbox.key;"
> + command="toolbox-cmd-close"/>
I prefer the way we did it in Bug 1162848 if for nothing else but consistency, but also because you can see the modifiers here next to the key.
So we would have two disabled keys (toolbox-key-toggle and toolbox-key-toggle-osx) then in the js enable the correct one depending on platform, like https://hg.mozilla.org/mozilla-central/rev/2b9780ca7aa8#l2.55.
Attachment #8694132 -
Flags: review?(bgrinstead)
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #8694224 -
Flags: review?(bgrinstead)
Assignee | ||
Updated•9 years ago
|
Attachment #8694132 -
Attachment is obsolete: true
Comment 5•9 years ago
|
||
Comment on attachment 8694224 [details] [diff] [review]
patch v2
Review of attachment 8694224 [details] [diff] [review]:
-----------------------------------------------------------------
Need to remove the * in jar.mn to get rid of preprocessing
Attachment #8694224 -
Flags: review?(bgrinstead) → review+
Assignee | ||
Comment 6•9 years ago
|
||
Assignee | ||
Comment 7•9 years ago
|
||
Assignee | ||
Comment 8•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/91642bf07cd0aaba3a589d52c2c063c5c8919e97
Bug 1229328 - Remove preprocessing from toolbox-window.xul. r=bgrins
Comment 9•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•