Mark Banner (:standard8) Assignee
	Description • 9 years ago

STR:

1) Start an older version of Firefox (e.g. 44) with a fresh profile
2) Right-click on the Hello button, and select "Remove from toolbar"
3) Exit Firefox
4) Start the latest version after bug 1223573 landed

Expected Results

=> Hello button is not on the toolbar

Actual Results

=> Hello button appears on the toolbar

Bug 1229123 has a fix for the customisable UI. I think we just have to add the loop-button to the list it has added, and then we'll be fine.

	Mark Banner (:standard8) Assignee
	Comment 1 • 9 years ago

Tagging for this iteration, as we need to fix this before we move to aurora.

	alex_mayorga
	Comment 2 • 9 years ago

¡Hola Mark!

Is this why Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0 ID:20151201030226 CSet: 66a6d7ec9534b9d7847b665142fef0dd87623768 shows this in "Browser Console"?

[CustomizableUI] Custom widget with id loop-button does not return a valid node CustomizableUI.jsm:173
no element found aboutNetError.xhtml:1:1

¡Gracias!

	:Gijs (he/him)
	Comment 3 • 9 years ago

(In reply to alex_mayorga from comment #2)
> ¡Hola Mark!
> 
> Is this why Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
> Firefox/45.0 ID:20151201030226 CSet:
> 66a6d7ec9534b9d7847b665142fef0dd87623768 shows this in "Browser Console"?
> 
> [CustomizableUI] Custom widget with id loop-button does not return a valid
> node CustomizableUI.jsm:173
> no element found aboutNetError.xhtml:1:1
> 
> ¡Gracias!

No, that's bug 1229471, and it is not related.

	Mark Banner (:standard8) Assignee
	Comment 4 • 9 years ago

This is based on the patch in bug 1215694, and fixes the issue in local testing.

Gijs, can you review this and check there's nothing else you think we'll need?

	:Gijs (he/him)
	Comment 5 • 9 years ago

Comment on attachment 8694701 [details] [diff] [review]
Buttons removed from the toolbar will re-appear when the Loop system add-on is activated.

Review of attachment 8694701 [details] [diff] [review]:
-----------------------------------------------------------------

You'll race with the pocket addition, but yes, I think this is all you need.

	Pulsebot
	Comment 6 • 9 years ago

https://hg.mozilla.org/integration/fx-team/rev/a8760b15e213

	Carsten Book [:Tomcat]
	Comment 7 • 9 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/a8760b15e213

	Ada [:adalucinet]
	Comment 8 • 9 years ago

Reproduced under Windows 7 64-bit: after removing the button in Developer Edition 44.0a2 and launching Nightly from 2015-12-01 with the same profile, the Hello button is available in the toolbar.

Verified fixed with latest 45.0a1 (from 2015-12-07), across platforms [1].

[1] Ubuntu 14.04 32-bit, Windows 7 64-bit and Mac OS X 10.11