Closed
Bug 1229605
Opened 9 years ago
Closed 9 years ago
Allow Opus in MSE without enabling VP9 (with media.mediasource.webm.enabled pref)
Categories
(Core :: Audio/Video: Playback, defect)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla45
People
(Reporter: cpeterson, Assigned: jya)
References
Details
Attachments
(1 file)
(deleted),
patch
|
ajones
:
review+
ritu
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
YouTube currently serves AAC audio to Firefox users watching H.264 or VP9. YouTube serves Opus to Chrome users. Unfortunately, Firefox's MSE implementation only supports Opus paired with VP9. We would like to be able to play Opus regardless of video codec (or container?).
Assignee | ||
Comment 1•9 years ago
|
||
I'm not aware of such restrictions.
I certainly see us being served webm with opus only content if I enable mediasource with webm.
What make you think we don't support opus only webm ?
from playing: https://www.youtube.com/watch?v=XqLTe8h0-jo
950272[118b06b40]: MediaSource(136f6f220)::AddSourceBuffer: AddSourceBuffer(aType=audio/webm; codecs="opus")
followed by:
62935040[1006b8730]: TrackBuffersManager(11914a000:audio/webm)::ProcessFrames: Processing audio/webm; codecs=opus frame(pts:0 end:21000, dts:0, duration:21000, kf:1)
62935040[1006b8730]: TrackBuffersManager(11914a000:audio/webm)::ProcessFrames: Processing audio/webm; codecs=opus frame(pts:21000 end:41000, dts:21000, duration:20000, kf:1)
The issue is youtube not serving us opus with h264, nothing to do with a limitation on our part.
I don't even think the old MSE architecture ever had that limitation either.
Status: NEW → UNCONFIRMED
Ever confirmed: false
Flags: needinfo?(cpeterson)
Assignee | ||
Comment 2•9 years ago
|
||
oh I see what you mean.
Our pref is for webm or mp4 ; we can't enable webm without also enabling vp9/vp8.
We don't have anything available that would allow one without also enabling the other.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jyavenard
Reporter | ||
Comment 3•9 years ago
|
||
(In reply to Jean-Yves Avenard [:jya] from comment #1)
> I certainly see us being served webm with opus only content if I enable
> mediasource with webm.
>
> What make you think we don't support opus only webm ?
That's what Anthony told me. :)
> The issue is youtube not serving us opus with h264, nothing to do with a
> limitation on our part.
I don't know if YouTube actually serves H.264 + Opus. YouTube says they serve Opus to nearly all Chrome users and we know they prefer VP9 over H.264. They might only support VP9 + Opus. I can ask. If they don't, then maybe there is little need to fix this bug.
Flags: needinfo?(cpeterson)
Summary: Support Opus in MSE without VP9 video → Allow Opus in MSE without enabling VP9 (with media.mediasource.webm.enabled pref)
Assignee | ||
Comment 4•9 years ago
|
||
This adds a media.mediasource.webm.audio.enabled preference (true by default) to disable opus or vorbis audio in webm mediasource.
Attachment #8695176 -
Flags: review?(ajones)
Reporter | ||
Comment 5•9 years ago
|
||
btw, YouTube says they serve Opus to nearly 100% of Chrome users. When we're ready, they can run A/B tests comparing Opus vs AAC for Firefox users.
Updated•9 years ago
|
Attachment #8695176 -
Flags: review?(ajones) → review+
Comment 7•9 years ago
|
||
bugherder |
Status: UNCONFIRMED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Reporter | ||
Updated•9 years ago
|
Reporter | ||
Comment 8•9 years ago
|
||
Comment on attachment 8695176 [details] [diff] [review]
[MSE] Allow webm/audio independently of video.
Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]: YouTube users will continue to receive AAC, which is slightly lower quality audio than Opus.
[Describe test coverage new/current, TreeHerder]: In Firefox 43, users without AAC platform decoders (e.g. 100% of Windows XP, 2% of other Windows versions, and 3% of Linux) already receive Opus as a fallback (bug 1217170).
[Risks and why]: Medium risk, because we will be using the codec for more content with more users. However, YouTube can control whether they serve AAC or Opus on the server side. Uplifting this to Beta 44 will make it easier for YouTube to selectively A/B test Firefox's Opus vs AAC before enabling for our release users.
[String/UUID change made/needed]: N/A
Attachment #8695176 -
Flags: approval-mozilla-beta?
Comment on attachment 8695176 [details] [diff] [review]
[MSE] Allow webm/audio independently of video.
Taking it, Beta44+
Attachment #8695176 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 10•9 years ago
|
||
bugherder uplift |
Comment 11•9 years ago
|
||
bugherder uplift |
status-b2g-v2.5:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•