Closed
Bug 1229694
Opened 9 years ago
Closed 8 years ago
[devedition theme] Toolbar button active/open styles are not correctly applied in normal (non-private) windows
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
RESOLVED
WORKSFORME
Firefox 53
People
(Reporter: arni2033, Unassigned)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
image/png
|
Details |
screenshot 1 - [dev theme] Toolbar buttons styling is inconsistent.png
>>> My Info: Win7_64, Nightly 45, 32bit, ID 20151201030226
STR:
1. Open menu (≡) -> customization, set Devtools theme (dark or light theme - doesn't matter)
2. Open private browser window and not private one
3. Click menu button (≡) in private window and in not private one
Result:
The visual appearance of buttons is different
Expectations:
The buttons with opened widgets/popups should look the same (like buttons in private window).
I first thought that the intent was to completely change the styling, but in bug 1215093 noone even
mentioned devtools theme (which is also "lightweight theme" somehow). So it clearly wasn't planned
I set keyword "regression" because styling became inconsistent
|
||
Comment 1•9 years ago
|
||
Dão, any chance you can look at this - last beta is this week, and the regressing bug was uplifted to 43. :-(
|
||
Comment 2•9 years ago
|
||
(In reply to :Gijs Kruitbosch from comment #1)
> Dão, any chance you can look at this - last beta is this week, and the
> regressing bug was uplifted to 43. :-(
How is that relevant given that this is a dev edition bug?
Flags: needinfo?(dao)
|
|
||
Comment 3•9 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #2)
> (In reply to :Gijs Kruitbosch from comment #1)
> > Dão, any chance you can look at this - last beta is this week, and the
> > regressing bug was uplifted to 43. :-(
>
> How is that relevant given that this is a dev edition bug?
Is it? The original bug changed lwthemes, it seems likely this will affect those, too.
|
|
||
Comment 4•9 years ago
|
||
Ordinary lightweight themes aren't affected as far as I can tell.
status-firefox43:
affected → ---
|
|
||
Updated•8 years ago
|
Notably that it was marked as dependent on bug 854126 that is going to break this completely.
Summary: [dev theme] Toolbar buttons styling is inconsistent between normal and private windows → [dev theme] Toolbar buttons styling is broken in not private windows after bug 1215093 (styling isn't applied)
|
|
||
Updated•8 years ago
|
Summary: [dev theme] Toolbar buttons styling is broken in not private windows after bug 1215093 (styling isn't applied) → [devedition theme] Toolbar button active/open styles are not correctly applied in normal (non-private) windows
|
|
||
Comment 6•8 years ago
|
||
I believe bug 1314091 and bug 854126 fixed this.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
Target Milestone: --- → Firefox 53
You need to log in
before you can comment on or make changes to this bug.
Description
•