Closed
Bug 1229923
Opened 9 years ago
Closed 9 years ago
Flash of 'paused' state on debugger startup
Categories
(DevTools :: Debugger, defect)
DevTools
Debugger
Tracking
(firefox45 fixed)
RESOLVED
FIXED
Firefox 45
Tracking | Status | |
---|---|---|
firefox45 | --- | fixed |
People
(Reporter: bgrins, Assigned: jlong)
References
Details
Attachments
(2 files)
(deleted),
image/gif
|
Details | |
(deleted),
patch
|
bgrins
:
review+
|
Details | Diff | Splinter Review |
When I open the debugger panel I see a moment when the pause button turns into a blue play button (as if the debugger is paused). After a second it goes back to normal. See attached gif.
I'm assuming this is due to Bug 1200798.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jlong
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8695339 -
Flags: review?(bgrinstead)
Assignee | ||
Comment 2•9 years ago
|
||
Assignee | ||
Comment 3•9 years ago
|
||
I was calling `onNavigate` on startup which is wrong, because all I wanted to do was load sources. In `onNavigate` the thread state is checked and the button is updated, and the JS engine is paused for a second on load, so it was reflecting that.
Reporter | ||
Comment 4•9 years ago
|
||
Comment on attachment 8695339 [details] [diff] [review]
1229923.patch
Review of attachment 8695339 [details] [diff] [review]:
-----------------------------------------------------------------
Fixes the problem for me. Is there a reasonable way to add a regression test for this?
Attachment #8695339 -
Flags: review?(bgrinstead) → review+
Reporter | ||
Updated•9 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•9 years ago
|
||
(In reply to Brian Grinstead [:bgrins] from comment #4)
>
> Fixes the problem for me. Is there a reasonable way to add a regression
> test for this?
I don't think it needs a test. We would be testing that the ThreadState._update function is not called on startup which I think is too specific of a workflow to be in a test. Writing tests like that make it hard to refactor in the future (having just gone through updating a lot of tests...)
I'd be down for a test if we were looking for a specific action to happen. I don't think every single change needs a test though, especially as I clean up code from the refactoring.
Comment 7•9 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Updated•9 years ago
|
QA Whiteboard: [good first verify]
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•