Closed
Bug 1230135
Opened 9 years ago
Closed 9 years ago
[Static Analysis][Dereference Null Return Value] Function DOMSVGPathSegList::InsertItemBefore from DOMSVGPathSegList.cpp
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla45
| Tracking | Status | |
|---|---|---|
| firefox45 | --- | fixed |
People
(Reporter: andi, Assigned: andi)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: CID 1338372 )
Attachments
(1 file)
|
(deleted),
patch
|
longsonr
:
review+
|
Details | Diff | Splinter Review |
The Static Analysis tool Scan-Build added value returned by GetDOMWrapperIfExists(InternalAList().GetAnimValKey()) to variable animVal can be NULL leading to a potential null pointer dereference later on.
|
Assignee | |
Updated•9 years ago
|
Whiteboard: CID 1338372
|
|
Assignee | |
Comment 1•9 years ago
|
||
Hello Jonathan,
Could you please take a look other this patch?
THX
Attachment #8695278 -
Flags: review?(jwatt)
|
|
Assignee | |
Updated•9 years ago
|
Blocks: coverity-analysis
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8695278 [details] [diff] [review]
Bug 1230135.diff
stealing as this is my code.
MOZ_ASSERT(animVal, "AnimListMirrorsBaseList() promised a non-null animVal");
would be better but the text doesn't matter that much.
Attachment #8695278 -
Flags: review?(jwatt) → review+
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
|
||
Comment 4•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in
before you can comment on or make changes to this bug.
Description
•