Closed
Bug 1230197
Opened 9 years ago
Closed 9 years ago
Plumb simulcast from JsepTrack to webrtc.org
Categories
(Core :: WebRTC: Audio/Video, defect, P1)
Core
WebRTC: Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla46
| backlog | webrtc/webaudio+ |
People
(Reporter: bwc, Assigned: bwc)
References
Details
Attachments
(1 file, 1 obsolete file)
This covers the work of configuring simulcast in the webrtc.org code based on the negotiated details in JsepTrack.
|
Assignee | |
Comment 1•9 years ago
|
||
|
|
Assignee | |
Comment 2•9 years ago
|
||
Bug 1230197: (WIP) Plumb negotiated simulcast down to webrtc.org, without RID.
|
|
Assignee | |
Comment 3•9 years ago
|
||
Comment on attachment 8697034 [details]
MozReview Request: Bug 1230197: Plumb negotiated simulcast down to webrtc.org. r?jesup
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/27491/diff/1-2/
Attachment #8697034 -
Attachment description: MozReview Request: Bug 1230197: (WIP) Plumb negotiated simulcast down to webrtc.org, without RID. → MozReview Request: Bug 1230197: (WIP) Plumb negotiated simulcast down to webrtc.org.
|
|
Assignee | |
Comment 4•9 years ago
|
||
Bug 1231507 - Part 1: selectSsrc chrome-only API for SSRC-based filtering of receive tracks.
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8697034 -
Flags: feedback?(rjesup)
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8697314 -
Attachment is obsolete: true
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8697034 [details]
MozReview Request: Bug 1230197: Plumb negotiated simulcast down to webrtc.org. r?jesup
https://reviewboard.mozilla.org/r/27491/#review24845
::: media/webrtc/signaling/src/media-conduit/VideoConduit.cpp:1807
(Diff revision 2)
> + stream.numberOfTemporalLayers = 1; // TODO: Ask jesup about this
1 is correct
::: media/webrtc/signaling/src/media-conduit/VideoConduit.cpp:1813
(Diff revision 2)
> + stream.rid[sizeof(stream.rid) - 1] = 0;
We did memset to 0 the buffer; this isn't strictly necessary - but I don't mind the minor redundancy; it makes it less fragile. Up to you
Attachment #8697034 -
Flags: review+
|
|
||
Updated•9 years ago
|
Attachment #8697034 -
Flags: review+
Attachment #8697034 -
Flags: feedback?(rjesup)
Attachment #8697034 -
Flags: feedback+
|
|
Assignee | |
Comment 6•9 years ago
|
||
Comment on attachment 8697034 [details]
MozReview Request: Bug 1230197: Plumb negotiated simulcast down to webrtc.org. r?jesup
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/27491/diff/2-3/
Attachment #8697034 -
Attachment description: MozReview Request: Bug 1230197: (WIP) Plumb negotiated simulcast down to webrtc.org. → MozReview Request: Bug 1230197: Plumb negotiated simulcast down to webrtc.org. r?jesup
Attachment #8697034 -
Flags: feedback+ → review?(rjesup)
|
|
||
Comment 7•9 years ago
|
||
Comment on attachment 8697034 [details]
MozReview Request: Bug 1230197: Plumb negotiated simulcast down to webrtc.org. r?jesup
https://reviewboard.mozilla.org/r/27491/#review24861
Attachment #8697034 -
Flags: review?(rjesup) → review+
|
|
||
Updated•9 years ago
|
backlog: --- → webrtc/webaudio+
Rank: 15
Priority: -- → P1
|
|
Assignee | |
Comment 8•9 years ago
|
||
|
|
Assignee | |
Comment 9•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9b9c4fa7b9eb247da0777faa4c14eb3eedb26c28
Bug 1230197: Plumb negotiated simulcast down to webrtc.org. r=jesup
|
||
Comment 10•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•