Closed Bug 1230589 Opened 9 years ago Closed 9 years ago

Build failure for all L devices: system/bluetoothd/src/bt-pan-io.c:303:5: error: (near initialization for 'btpan_callbacks.control_state_cb') [-Werror]

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

Product:
Firefox OS Graveyard
Component:
Bluetooth
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: gerard-majax, Unassigned)

References

Details

(Keywords: regression)

> system/bluetoothd/src/bt-pan-io.c: In function 'register_bt_pan': > system/bluetoothd/src/bt-pan-io.c:303:5: error: initialization from incompatible pointer type [-Werror] > .control_state_cb = control_state_cb, > ^ > system/bluetoothd/src/bt-pan-io.c:303:5: error: (near initialization for 'btpan_callbacks.control_state_cb') [-Werror] > cc1: all warnings being treated as errors That would have been discovered if bug 1183823 was fixed
Flags: needinfo?(tzimmermann)
Flags: needinfo?(ttung)
in hardware/libhardware/include/hardware/bt_pan.h: > typedef void (*btpan_control_state_callback)(btpan_control_state_t state, int local_role, bt_status_t error, const char* ifname); in system/bluetoothd/src/bt-pan-io.c: > static void control_state_cb(btpan_control_state_t state, bt_status_t error, int local_role, const char* ifname)
Nexus 5 L: https://treeherder.mozilla.org/logviewer.html#?job_id=3516300&repo=b2g-inbound https://treeherder.mozilla.org/logviewer.html#?job_id=3516288&repo=b2g-inbound
Summary: Build failure for Z3c L: system/bluetoothd/src/bt-pan-io.c:303:5: error: (near initialization for 'btpan_callbacks.control_state_cb') [-Werror] → Build failure for all L devices: system/bluetoothd/src/bt-pan-io.c:303:5: error: (near initialization for 'btpan_callbacks.control_state_cb') [-Werror]
I've reverted the pull request on that repository, so this should clear up soon.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Sorry about this. The patch was merge prematurely. I left a note in the bug report on how to best avoid this. BT APIs seem to change with each version of Android.
Flags: needinfo?(tzimmermann)
Sorry for late reply and this. I should not ask for "checkin-needed" prematurely. I only test the patch in flame-kk. I did not consider that callback function may be different in other devices. I will test the patch in different environments and fix all problems.
Flags: needinfo?(ttung)
You need to log in before you can comment on or make changes to this bug.